Skip to content

feat: Add CUBE limitation in Presto docs#27098

Merged
natashasehgal merged 1 commit intoprestodb:masterfrom
natashasehgal:export-D92542806
Feb 7, 2026
Merged

feat: Add CUBE limitation in Presto docs#27098
natashasehgal merged 1 commit intoprestodb:masterfrom
natashasehgal:export-D92542806

Conversation

@natashasehgal
Copy link
Copy Markdown
Contributor

@natashasehgal natashasehgal commented Feb 6, 2026

Documentation

  • Clarify in the SELECT documentation that CUBE is limited to 30 columns (2^30 group sets).

Motivation and Context

Add CUBE limitation in Presto docs
CUBE Is limited to n=30 (i.e 2^30 sets) and should be documented

https://github.com/prestodb/presto/blob/master/presto-main-base/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java#L3913

Issue: #27096

Impact

NA

Test Plan

NA

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

== NO RELEASE NOTE ==

Differential Revision: D92542806

@natashasehgal natashasehgal requested review from a team, elharo and steveburnett as code owners February 6, 2026 19:40
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Feb 6, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 6, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Documents the existing Presto CUBE operator limitation (maximum n=30, i.e., 2^30 sets) in the SQL SELECT reference docs.

File-Level Changes

Change Details Files
Document CUBE grouping set limitation in the SELECT statement reference.
  • Add a note describing the maximum supported CUBE size (n=30) and corresponding 2^30 grouping sets limit
  • Clarify that this is an engine limitation so users can understand and anticipate errors when exceeding the limit
presto-docs/src/main/sphinx/sql/select.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

@github-project-automation github-project-automation bot moved this from 🆕 Unprioritized to ✅ Done in Presto Documentation Feb 6, 2026
@natashasehgal natashasehgal merged commit 28f7e58 into prestodb:master Feb 7, 2026
81 of 85 checks passed
@natashasehgal natashasehgal deleted the export-D92542806 branch February 7, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants