Skip to content

fix(build): Undefined Iceberg* symbols#27094

Merged
PingLiuPing merged 1 commit intoprestodb:masterfrom
PingLiuPing:lp_fix_build
Feb 11, 2026
Merged

fix(build): Undefined Iceberg* symbols#27094
PingLiuPing merged 1 commit intoprestodb:masterfrom
PingLiuPing:lp_fix_build

Conversation

@PingLiuPing
Copy link
Copy Markdown
Contributor

@PingLiuPing PingLiuPing commented Feb 6, 2026

Description

Fix build break.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

Summary by Sourcery

Build:

  • Link the velox_hive_iceberg_splitreader library into various native execution and trace test binaries to fix build-time undefined symbol errors.

@PingLiuPing PingLiuPing requested a review from zacw7 February 6, 2026 10:21
@PingLiuPing PingLiuPing requested review from a team as code owners February 6, 2026 10:21
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 6, 2026
@prestodb-ci prestodb-ci requested review from a team, BryanCutler and aaneja and removed request for a team February 6, 2026 10:21
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 6, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes a native build break by linking Iceberg’s Hive split reader library into several Presto native test binaries that use Hive/Iceberg functionality but were previously missing that dependency, causing undefined Iceberg* symbols at link time.

File-Level Changes

Change Details Files
Link missing Iceberg split reader library into native execution and trace test targets to resolve undefined Iceberg* symbols.
  • Add velox_hive_iceberg_splitreader to the link libraries of Presto native type-related test targets that already depend on Hive/Velox DWIO components.
  • Add velox_hive_iceberg_splitreader to the link libraries of the trace tool test target that uses Hive and query trace replay components.
presto-native-execution/presto_cpp/main/types/tests/CMakeLists.txt
presto-native-execution/presto_cpp/main/tool/trace/tests/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since velox_hive_iceberg_splitreader is now a dependency for several test targets, consider factoring the shared link library list into a common CMake variable or function to avoid duplication and keep future changes to these dependencies in sync.
  • If Iceberg support is optionally buildable/disabled via a CMake flag, please double-check that linking velox_hive_iceberg_splitreader is guarded or handled in a way that won’t break configurations where Iceberg is not compiled.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `velox_hive_iceberg_splitreader` is now a dependency for several test targets, consider factoring the shared link library list into a common CMake variable or function to avoid duplication and keep future changes to these dependencies in sync.
- If Iceberg support is optionally buildable/disabled via a CMake flag, please double-check that linking `velox_hive_iceberg_splitreader` is guarded or handled in a way that won’t break configurations where Iceberg is not compiled.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tony for this code. I'm approving for now as this is a build failure.

But please implement the sourcery-ai suggestion in a subsequent cleanup PR.

Since velox_hive_iceberg_splitreader is now a dependency for several test targets, consider factoring the shared link library list into a common CMake variable or function to avoid duplication and keep future changes to these dependencies in sync.

@PingLiuPing
Copy link
Copy Markdown
Contributor Author

@tdcmeehan Would you please take a look at this PR? The build break is caused by velox code change. Thank you.

Copy link
Copy Markdown
Member

@zacw7 zacw7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Copy Markdown
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PingLiuPing

@PingLiuPing PingLiuPing merged commit 876baba into prestodb:master Feb 11, 2026
112 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants