fix(docs): Update link in Hudi documentation to RFC-44#27092
fix(docs): Update link in Hudi documentation to RFC-44#27092steveburnett merged 2 commits intoprestodb:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Hudi connector documentation to point to the correct RFC-44 reference/link for Hudi RFC details. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `presto-docs/src/main/sphinx/connector/hudi.rst:9` </location>
<code_context>
The Hudi connector enables querying `Hudi <https://hudi.apache.org/docs/overview/>`_ tables
synced to Hive metastore. The connector usesthe metastore only to track partition locations.
It makes use of the underlying Hudi filesystem and input formats to list data files. To learn
-more about the design of the connector, please check out `RFC-40 <https://github.com/apache/hu
</code_context>
<issue_to_address>
**issue (typo):** Missing space in "usesthe"; should be "uses the".
In that sentence, insert a space so it reads "uses the metastore only to track partition locations."
```suggestion
synced to Hive metastore. The connector uses the metastore only to track partition locations.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -8,7 +8,7 @@ Overview | |||
| The Hudi connector enables querying `Hudi <https://hudi.apache.org/docs/overview/>`_ tables | |||
| synced to Hive metastore. The connector usesthe metastore only to track partition locations. | |||
There was a problem hiding this comment.
issue (typo): Missing space in "usesthe"; should be "uses the".
In that sentence, insert a space so it reads "uses the metastore only to track partition locations."
| synced to Hive metastore. The connector usesthe metastore only to track partition locations. | |
| synced to Hive metastore. The connector uses the metastore only to track partition locations. |
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks for catching this!
|
Please edit the PR title to pass the required failing test. Maybe something like:
When the failing test is passed, this PR is ready to merge. Thanks! |
|
@steveburnett Thank you for the feedback. I’ve also updated the PR title, and all CI checks have passed. |
Description
Ensure that the Hudi RFC details are accurately documented.
Motivation and Context
Ensure that the Hudi RFC details are accurately documented.
Impact
NA
Test Plan
NA
Contributor checklist
Release Notes
Summary by Sourcery
Documentation: