Add support for America/Coyhaique timezone#27076
Open
ReemaAlzaid wants to merge 1 commit intoprestodb:masterfrom
Open
Add support for America/Coyhaique timezone#27076ReemaAlzaid wants to merge 1 commit intoprestodb:masterfrom
ReemaAlzaid wants to merge 1 commit intoprestodb:masterfrom
Conversation
- Added America/Coyhaique to zone-index.properties with ID 2234
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds support for the America/Coyhaique timezone in Presto by assigning it a new numeric ID in the timezone zone-index properties file. Flow diagram for timezone resolution including America/Coyhaiqueflowchart TD
A[User queries with timezone name America/Coyhaique] --> B[Presto timezone loader]
B --> C[Load zone-index.properties]
C --> D{Find timezone name key}
D -->|Found America/Coyhaique| E[Map to numeric ID 2234]
D -->|Not found| F[Fallback or error: unknown timezone]
E --> G[Use numeric ID 2234 in internal timezone index]
G --> H[Execute query with correct America/Coyhaique offset rules]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If
zone-index.propertiesis generated or kept in sync with an upstream source (e.g., TZDB data or a generator script), consider updating that source instead of editing the file directly so that future regenerations don’t drop the newAmerica/Coyhaiqueentry.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If `zone-index.properties` is generated or kept in sync with an upstream source (e.g., TZDB data or a generator script), consider updating that source instead of editing the file directly so that future regenerations don’t drop the new `America/Coyhaique` entry.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
The more comprehensive PR is here: #26981 |
Contributor
Should this one be closed? |
Contributor
Should this PR be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
America/Coyhaiquetimezone to Presto's timezone index by adding a new entry to thezone-index.propertiesfile. solves #27075Motivation and Context
This change addresses the need for comprehensive timezone support in Presto, particularly for South American regions
Contributor checklist
Release Notes
Summary by Sourcery
New Features: