Skip to content

Add support for America/Coyhaique timezone#27076

Open
ReemaAlzaid wants to merge 1 commit intoprestodb:masterfrom
ReemaAlzaid:add-america-coyhaique-timezone
Open

Add support for America/Coyhaique timezone#27076
ReemaAlzaid wants to merge 1 commit intoprestodb:masterfrom
ReemaAlzaid:add-america-coyhaique-timezone

Conversation

@ReemaAlzaid
Copy link
Copy Markdown

@ReemaAlzaid ReemaAlzaid commented Feb 3, 2026

Description

This PR adds support for the America/Coyhaique timezone to Presto's timezone index by adding a new entry to the zone-index.properties file. solves #27075

Motivation and Context

This change addresses the need for comprehensive timezone support in Presto, particularly for South American regions

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

== NO RELEASE NOTE ==

Summary by Sourcery

New Features:

  • Introduce support for the America/Coyhaique timezone in the Presto timezone index.

- Added America/Coyhaique to zone-index.properties with ID 2234
@ReemaAlzaid ReemaAlzaid requested review from a team and elharo as code owners February 3, 2026 21:48
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 3, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds support for the America/Coyhaique timezone in Presto by assigning it a new numeric ID in the timezone zone-index properties file.

Flow diagram for timezone resolution including America/Coyhaique

flowchart TD
    A[User queries with timezone name America/Coyhaique] --> B[Presto timezone loader]
    B --> C[Load zone-index.properties]
    C --> D{Find timezone name key}
    D -->|Found America/Coyhaique| E[Map to numeric ID 2234]
    D -->|Not found| F[Fallback or error: unknown timezone]
    E --> G[Use numeric ID 2234 in internal timezone index]
    G --> H[Execute query with correct America/Coyhaique offset rules]
Loading

File-Level Changes

Change Details Files
Extend timezone index with America/Coyhaique entry.
  • Append a new numeric ID mapping for America/Coyhaique at the end of the timezone list
  • Ensure the new ID (2234) follows the existing sequential indexing used for other timezones
presto-common/src/main/resources/com/facebook/presto/common/type/zone-index.properties

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Feb 3, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: ReemaAlzaid / name: Reema Alzaid (ac039c6)

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • If zone-index.properties is generated or kept in sync with an upstream source (e.g., TZDB data or a generator script), consider updating that source instead of editing the file directly so that future regenerations don’t drop the new America/Coyhaique entry.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- If `zone-index.properties` is generated or kept in sync with an upstream source (e.g., TZDB data or a generator script), consider updating that source instead of editing the file directly so that future regenerations don’t drop the new `America/Coyhaique` entry.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tdcmeehan
Copy link
Copy Markdown
Contributor

The more comprehensive PR is here: #26981

@steveburnett
Copy link
Copy Markdown
Contributor

The more comprehensive PR is here: #26981

Should this one be closed?

@steveburnett
Copy link
Copy Markdown
Contributor

The more comprehensive PR is here: #26981

Should this PR be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants