Skip to content

fix(native): Fix Dereference expression index type in VeloxToPrestoExprConverter #27057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pramodsatya merged 1 commit into from
Feb 6, 2026
Merged

fix(native): Fix Dereference expression index type in VeloxToPrestoExprConverter #27057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/types/VeloxToPrestoExpr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ SpecialFormExpressionPtr VeloxToPrestoExprConverter::getDereferenceExpression(
const auto dereferenceInputs = std::vector<velox::core::TypedExprPtr>{
dereferenceExpr->inputs().at(0),
std::make_shared<velox::core::ConstantTypedExpr>(
velox::BIGINT(), static_cast<int64_t>(dereferenceExpr->index()))};
velox::INTEGER(), static_cast<int32_t>(dereferenceExpr->index()))};
for (const auto& input : dereferenceInputs) {
const auto rowExpr = getRowExpression(input);
protocol::to_json(j, rowExpr);
Expand Down
14 changes: 14 additions & 0 deletions ...ive-sidecar-plugin/src/test/java/com/facebook/presto/sidecar/TestNativeSidecarPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,20 @@ public void testNativeExpressionOptimizer()
assertQuerySucceeds(session, "SELECT table_name, COALESCE(abs(ordinal_position), 0) as abs_pos FROM information_schema.columns WHERE table_catalog = 'hive' AND table_name IN ('nation', 'region') ORDER BY table_name, ordinal_position");
assertQuerySucceeds(session, "SELECT table_name, ordinal_position FROM information_schema.columns WHERE abs(ordinal_position) IN (1, 2, 3) AND table_catalog = 'hive' AND table_name != 'roles' ORDER BY table_name, ordinal_position");
assertQuerySucceeds(session, "select lower(table_name) from information_schema.tables where table_name = 'lineitem' or table_name = 'LINEITEM'");

// Test dereference expression.
assertQuerySucceeds(session,
"select cast(row(row(row(random(10), if(random(10) >= 0, 2)), random(10)), random(100)) AS row(x row(y row(a int, b int), c int), d int))[1][1][2]");
assertQuerySucceeds(session,
"select cast(row(row(row(random(10), if(random(10) < 0, 2)), random(10)), random(100)) AS row(x row(y row(a int, b int), c int), d int))[1][2]");
assertQuerySucceeds(session,
"select cast(row(row(null, random(10)), random(100)) AS row(x row(y row(a int, b int), c int), d int))[1][1][1]");
assertQuerySucceeds(session,
"select cast(row(row(null, if(random(100) >= 0, 4)), random(10)) AS row(x row(y row(a int, b int), c int), d int))[2]");

// Test dereference expression with SQL invoked function, array_least_frequent.
assertQuerySucceeds(session, "SELECT array_least_frequent(array_agg(orderkey)) from orders");
assertQuerySucceeds(session, "SELECT array_least_frequent(array_agg(nationkey)) from nation");
}

@Test
Expand Down
Loading