feat: Add syntax support for CREATE VECTOR INDEX #27027
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.sql.tree; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Objects; | ||
| import java.util.Optional; | ||
|
|
||
| import static com.google.common.base.MoreObjects.toStringHelper; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class CreateVectorIndex | ||
| extends Statement | ||
| { | ||
| private final Identifier indexName; | ||
|
Comment on lines
+27
to
+28
Contributor
There was a problem hiding this comment. indexName should also be QualifiedName? |
||
| private final QualifiedName tableName; | ||
| private final List<Identifier> columns; | ||
| private final Optional<Expression> updatingFor; | ||
|
Contributor
There was a problem hiding this comment. Since this predicate may influence incremental index maintenance behavior, it may be useful to clarify whether this expression is expected to be interpreted by the engine or delegated to the connector during index update planning. This would help ensure alignment with the RFC’s expectation of connector-managed lifecycle and refresh semantics.
Member
Author
There was a problem hiding this comment. It will be interpreted by the engine to a where predicate. |
||
| private final List<Property> properties; | ||
|
|
||
| public CreateVectorIndex( | ||
| Identifier indexName, | ||
| QualifiedName tableName, | ||
| List<Identifier> columns, | ||
| Optional<Expression> updatingFor, | ||
| List<Property> properties) | ||
| { | ||
| this(Optional.empty(), indexName, tableName, columns, updatingFor, properties); | ||
| } | ||
|
|
||
| public CreateVectorIndex( | ||
| NodeLocation location, | ||
| Identifier indexName, | ||
| QualifiedName tableName, | ||
| List<Identifier> columns, | ||
| Optional<Expression> updatingFor, | ||
| List<Property> properties) | ||
| { | ||
| this(Optional.of(location), indexName, tableName, columns, updatingFor, properties); | ||
| } | ||
|
|
||
| private CreateVectorIndex( | ||
| Optional<NodeLocation> location, | ||
| Identifier indexName, | ||
| QualifiedName tableName, | ||
| List<Identifier> columns, | ||
| Optional<Expression> updatingFor, | ||
| List<Property> properties) | ||
| { | ||
| super(location); | ||
| this.indexName = requireNonNull(indexName, "indexName is null"); | ||
| this.tableName = requireNonNull(tableName, "tableName is null"); | ||
| this.columns = ImmutableList.copyOf(requireNonNull(columns, "columns is null")); | ||
| this.updatingFor = requireNonNull(updatingFor, "updatingFor is null"); | ||
| this.properties = ImmutableList.copyOf(requireNonNull(properties, "properties is null")); | ||
| } | ||
|
|
||
| public Identifier getIndexName() | ||
| { | ||
| return indexName; | ||
| } | ||
|
|
||
| public QualifiedName getTableName() | ||
| { | ||
| return tableName; | ||
| } | ||
|
|
||
| public List<Identifier> getColumns() | ||
| { | ||
| return columns; | ||
| } | ||
|
|
||
| public Optional<Expression> getUpdatingFor() | ||
| { | ||
| return updatingFor; | ||
| } | ||
|
|
||
| public List<Property> getProperties() | ||
| { | ||
| return properties; | ||
| } | ||
|
|
||
| @Override | ||
| public <R, C> R accept(AstVisitor<R, C> visitor, C context) | ||
| { | ||
| return visitor.visitCreateVectorIndex(this, context); | ||
| } | ||
|
|
||
| @Override | ||
| public List<Node> getChildren() | ||
| { | ||
| ImmutableList.Builder<Node> children = ImmutableList.builder(); | ||
| children.add(indexName); | ||
| children.addAll(columns); | ||
| updatingFor.ifPresent(children::add); | ||
| children.addAll(properties); | ||
| return children.build(); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() | ||
| { | ||
| return Objects.hash(indexName, tableName, columns, updatingFor, properties); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) | ||
| { | ||
| if (this == obj) { | ||
| return true; | ||
| } | ||
| if ((obj == null) || (getClass() != obj.getClass())) { | ||
| return false; | ||
| } | ||
| CreateVectorIndex o = (CreateVectorIndex) obj; | ||
| return Objects.equals(indexName, o.indexName) && | ||
| Objects.equals(tableName, o.tableName) && | ||
| Objects.equals(columns, o.columns) && | ||
| Objects.equals(updatingFor, o.updatingFor) && | ||
| Objects.equals(properties, o.properties); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() | ||
| { | ||
| return toStringHelper(this) | ||
| .add("indexName", indexName) | ||
| .add("tableName", tableName) | ||
| .add("columns", columns) | ||
| .add("updatingFor", updatingFor) | ||
| .add("properties", properties) | ||
| .toString(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be
instead of
identifier. Like create view or create table, as index is internally stored as a table.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gggrace14 , In our implementation the index is not stored as a catalog table but as a connector-managed index file (Stored in s3 based object storage). Because of this, the index name behaves more like a logical identifier rather than a fully qualified relation. Using identifier seemed appropriate in this case, whereas qualifiedName would imply the index itself is a catalog object similar to CREATE TABLE or CREATE VIEW.