Skip to content

misc: Remove unused includes#27026

Merged
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:export-D91374441
Jan 24, 2026
Merged

misc: Remove unused includes#27026
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:export-D91374441

Conversation

@amitkdutta
Copy link
Copy Markdown
Contributor

@amitkdutta amitkdutta commented Jan 24, 2026

Summary:
Clean up unused includes in presto_cpp/main to improve compilation times
and reduce unnecessary header dependencies:

  1. Announcer.cpp:

    • Removed folly/futures/Retrying.h - no retrying symbols used
    • Removed velox/common/memory/Memory.h - no memory pool symbols used
  2. PeriodicHeartbeatManager.cpp:

    • Removed velox/common/memory/Memory.h - no memory symbols used
  3. PrestoExchangeSource.cpp:

    • Replaced QueryContextManager.h with the more specific
      presto_protocol/core/presto_protocol_core.h which directly provides
      the protocol namespace symbols (DataSize, Duration, PRESTO__HEADER
      constants) that are actually used. This avoids pulling in heavy
      transitive dependencies from QueryContextManager.h like
      folly/Synchronized, folly/executors/
      , and velox/core/QueryCtx.h.

Summary by Sourcery

Clean up unused and overly broad header dependencies in presto_cpp main sources to reduce compile-time and transitive includes.

Enhancements:

  • Remove unused header includes from Announcer and PeriodicHeartbeatManager to simplify dependencies.
  • Narrow PrestoExchangeSource's dependency from QueryContextManager to the specific presto_protocol_core header that provides the required protocol types and constants.
== NO RELEASE NOTE ==

Summary:
Clean up unused includes in presto_cpp/main to improve compilation times
and reduce unnecessary header dependencies:

1. Announcer.cpp:
   - Removed `folly/futures/Retrying.h` - no retrying symbols used
   - Removed `velox/common/memory/Memory.h` - no memory pool symbols used

2. PeriodicHeartbeatManager.cpp:
   - Removed `velox/common/memory/Memory.h` - no memory symbols used

3. PrestoExchangeSource.cpp:
   - Replaced `QueryContextManager.h` with the more specific
     `presto_protocol/core/presto_protocol_core.h` which directly provides
     the protocol namespace symbols (DataSize, Duration, PRESTO_*_HEADER
     constants) that are actually used. This avoids pulling in heavy
     transitive dependencies from QueryContextManager.h like
     folly/Synchronized, folly/executors/*, and velox/core/QueryCtx.h.

Differential Revision: D91374441
@amitkdutta amitkdutta requested review from a team as code owners January 24, 2026 01:29
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jan 24, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Jan 24, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes unused header includes in several presto_cpp/main translation units and narrows one dependency from a heavy umbrella header to a specific protocol header, reducing compilation dependencies and potential build times without changing runtime behavior.

File-Level Changes

Change Details Files
Remove unused headers from Announcer implementation.
  • Dropped inclusion of folly/futures/Retrying.h since no retrying-related APIs are referenced.
  • Removed velox/common/memory/Memory.h because no memory pool or memory manager symbols are used.
presto-native-execution/presto_cpp/main/Announcer.cpp
Remove unused memory header from PeriodicHeartbeatManager.
  • Deleted include of velox/common/memory/Memory.h because the implementation no longer references any symbols from that header.
presto-native-execution/presto_cpp/main/PeriodicHeartbeatManager.cpp
Narrow PrestoExchangeSource’s dependency from a broad query context header to the specific protocol core header that provides the used symbols.
  • Replaced inclusion of presto_cpp/main/QueryContextManager.h with presto_cpp/presto_protocol/core/presto_protocol_core.h to directly import DataSize, Duration, and PRESTO_*_HEADER constants.
  • Kept other includes unchanged, thereby avoiding heavy transitive dependencies from QueryContextManager such as folly concurrency/executor and velox query context headers.
presto-native-execution/presto_cpp/main/PrestoExchangeSource.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@amitkdutta amitkdutta merged commit c57d320 into prestodb:master Jan 24, 2026
85 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants