test: Add end to end test for key_sampling_percent

[jkhaliqi]

Description

Add E2E tests for key_sampling_percent

Motivation and Context

As part of testing for facebookincubator/velox#16041

Impact

Test Plan

Added in E2E tests

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.
• If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Summary by Sourcery

Tests:

• Extend native string function E2E tests to validate key_sampling_percent using a variety of VARCHAR inputs.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an end-to-end native worker test coverage for the key_sampling_percent string function by extending the existing string functions test to create a temp table, populate it with a variety of VARCHAR values (including NULL and edge cases), and assert that key_sampling_percent executes successfully in native execution.

File-Level Changes

Change	Details	Files
Extend native string function E2E tests to cover key_sampling_percent on a temp VARCHAR table with diverse values.	Update the string functions test comment to reflect coverage of normalize and key_sampling_percent. After existing normalize() assertions, insert a variety of VARCHAR values (including NULL, short/long strings, numeric-like content, special characters, whitespace-only, and empty string) into a temporary table. Add an assertQuery invocation that runs key_sampling_percent(c0) on the populated temp table to validate native execution behavior. Preserve table cleanup via dropTableIfExists in the finally block.	presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeGeneralQueries.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[pramodsatya]

Thanks @jkhaliqi.

[jkhaliqi]

Tests related to key_sampling_percent on CI will pass once velox PR is in presto.

[aditi-pandit]

Thanks @jkhaliqi

[aditi-pandit]

@jkhaliqi : Do you get consistent results between Prestissimo and Java for this ? I feel we should be fine with just assertQuerySucceeds here.

[jkhaliqi]

@aditi-pandit E2E tests in place were passing with same results.

[aditi-pandit]

Thanks @jkhaliqi