Skip to content

chore(native): Remove unused variable in VeloxToPrestoExprConverter#27018

Merged
aditi-pandit merged 1 commit intoprestodb:masterfrom
pramodsatya:clnup_expr_conv
Jan 23, 2026
Merged

chore(native): Remove unused variable in VeloxToPrestoExprConverter#27018
aditi-pandit merged 1 commit intoprestodb:masterfrom
pramodsatya:clnup_expr_conv

Conversation

@pramodsatya
Copy link
Copy Markdown
Contributor

@pramodsatya pramodsatya commented Jan 23, 2026

Description

Removes unused $static variable from VeloxToPresto expression converter.

Motivation and Context

Cleanup code.

Impact

N/A.

== NO RELEASE NOTE ==

Summary by Sourcery

Chores:

  • Clean up an unused static variable definition in the VeloxToPresto expression converter code.

@pramodsatya pramodsatya requested review from a team as code owners January 23, 2026 00:30
Copilot AI review requested due to automatic review settings January 23, 2026 00:30
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 23, 2026
@prestodb-ci prestodb-ci requested review from a team and Mariamalmesfer and removed request for a team and Copilot January 23, 2026 00:30
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Jan 23, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes an unused static string constant from the VeloxToPresto expression converter to clean up the native execution codebase.

File-Level Changes

Change Details Files
Remove unused static string constant in VeloxToPresto expression converter call-expression handling.
  • Deleted the unused static constexpr string pointer representing "$static" from the call-expression conversion function.
  • Left the remaining call-expression JSON construction logic unchanged.
presto-native-execution/presto_cpp/main/types/VeloxToPrestoExpr.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pramodsatya

@aditi-pandit aditi-pandit merged commit b096c68 into prestodb:master Jan 23, 2026
124 of 126 checks passed
@pramodsatya pramodsatya deleted the clnup_expr_conv branch February 10, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants