fix(build): Fully qualify yield call to avoid java 17 compilation error

[kiersten-stokes]

Description

Updates yield call to use fully-qualified call

Motivation and Context

In java 14+, compilation will error if a restricted name is used and yield is a restricted in 14+.

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.
• If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Qualifies the yield call in PageBuffer to use WorkProcessor.ProcessState.yield() explicitly to avoid Java 14+ restricted identifier compilation errors.

Class diagram for updated PageBuffer yield call

classDiagram
    class PageBuffer {
        +WorkProcessor~Page~ pages()
    }

    class WorkProcessor {
        <<interface>> WorkProcessor
        +ProcessState~T~ ofResult(T result)
    }

    class ProcessState {
        <<static nested>> ProcessState
        +static ProcessState yield()
    }

    PageBuffer ..> WorkProcessor : uses
    WorkProcessor *-- ProcessState : defines

    %% Explicit reference showing fully-qualified call
    PageBuffer ..> ProcessState : calls yield() as WorkProcessor.ProcessState.yield()

Loading

File-Level Changes

Change	Details	Files
Qualify yield call to avoid conflict with Java restricted identifier.	Replace bare yield() return with explicit WorkProcessor.ProcessState.yield() within the pages() lambda implementation. Ensure the WorkProcessor.ProcessState static method is referenced unambiguously for compatibility with Java 14+ and 17 compilers.	presto-main-base/src/main/java/com/facebook/presto/operator/PageBuffer.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider adding a brief comment near the fully qualified WorkProcessor.ProcessState.yield() call explaining that this is required to avoid the Java 14+ restricted identifier issue so it’s not “cleaned up” back to the unqualified form in future refactors.
• It may be worth scanning the codebase for any other unqualified yield() usages from WorkProcessor.ProcessState to ensure consistent handling of the Java 14+ restriction across the project.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider adding a brief comment near the fully qualified `WorkProcessor.ProcessState.yield()` call explaining that this is required to avoid the Java 14+ restricted identifier issue so it’s not “cleaned up” back to the unqualified form in future refactors.
- It may be worth scanning the codebase for any other unqualified `yield()` usages from `WorkProcessor.ProcessState` to ensure consistent handling of the Java 14+ restriction across the project.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}