Skip to content

fix(native): Incorrect release build and make errors #26997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
czentgr merged 1 commit into from
Jan 21, 2026
Merged

fix(native): Incorrect release build and make errors #26997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/presto-release-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ jobs:
working-directory: presto-native-execution
run: |
df -h
docker compose build --build-arg EXTRA_CMAKE_FLAGS="
docker compose build --build-arg EXTRA_CMAKE_FLAGS=" \
-DPRESTO_ENABLE_PARQUET=ON \
-DPRESTO_ENABLE_REMOTE_FUNCTIONS=ON \
-DPRESTO_ENABLE_JWT=ON \
Expand Down
6 changes: 3 additions & 3 deletions presto-native-execution/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ clean: #: Delete all build artifacts
rm -rf $(BUILD_BASE_DIR)

velox-submodule: #: Check out code for velox submodule
git submodule sync --recursive
git submodule sync --recursive && \
git submodule update --init --recursive

submodules: velox-submodule
Expand All @@ -107,15 +107,15 @@ build: #: Build the software based in BUILD_DIR and BUILD_TYPE variables
cmake --build $(BUILD_BASE_DIR)/$(BUILD_DIR) -j $(NUM_THREADS)

debug: #: Build with debugging symbols
$(MAKE) cmake BUILD_DIR=debug BUILD_TYPE=Debug
$(MAKE) cmake BUILD_DIR=debug BUILD_TYPE=Debug && \
$(MAKE) build BUILD_DIR=debug

release: #: Build the release version
$(MAKE) cmake BUILD_DIR=release BUILD_TYPE=Release && \
$(MAKE) build BUILD_DIR=release

cmake-and-build: #: cmake and build without updating submodules which requires git
cmake -B "$(BUILD_BASE_DIR)/$(BUILD_DIR)" $(FORCE_COLOR) $(CMAKE_FLAGS) $(EXTRA_CMAKE_FLAGS)
cmake -B "$(BUILD_BASE_DIR)/$(BUILD_DIR)" $(FORCE_COLOR) $(CMAKE_FLAGS) $(EXTRA_CMAKE_FLAGS) && \
cmake --build $(BUILD_BASE_DIR)/$(BUILD_DIR) -j $(NUM_THREADS)

unittest: debug #: Build with debugging and run unit tests
Expand Down
Loading