Skip to content

misc: Add python language in RoutineCharacteristics #26962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feilong-liu merged 1 commit into from
Jan 14, 2026
Merged

misc: Add python language in RoutineCharacteristics #26962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...ava/com/facebook/presto/functionNamespace/json/JsonFileBasedFunctionNamespaceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@
import static com.facebook.presto.spi.StandardErrorCode.GENERIC_USER_ERROR;
import static com.facebook.presto.spi.StandardErrorCode.NOT_SUPPORTED;
import static com.facebook.presto.spi.function.FunctionVersion.notVersioned;
import static com.facebook.presto.spi.function.RoutineCharacteristics.Language.CPP;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkState;
import static com.google.common.collect.ImmutableList.toImmutableList;
import static com.google.common.collect.MoreCollectors.onlyElement;
import static java.lang.Long.parseLong;
Expand Down Expand Up @@ -138,7 +136,6 @@ private void populateNameSpaceManager(UdfFunctionSignatureMap udfFunctionSignatu

private SqlInvokedFunction createSqlInvokedFunction(String functionName, JsonBasedUdfFunctionMetadata jsonBasedUdfFunctionMetaData)
{
checkState(jsonBasedUdfFunctionMetaData.getRoutineCharacteristics().getLanguage().equals(CPP), "JsonFileBasedFunctionNamespaceManager only supports CPP UDF");
QualifiedObjectName qualifiedFunctionName = QualifiedObjectName.valueOf(new CatalogSchemaName(getCatalogName(), jsonBasedUdfFunctionMetaData.getSchema()), functionName);
List<String> parameterNameList = jsonBasedUdfFunctionMetaData.getParamNames();
List<TypeSignature> parameterTypeList = jsonBasedUdfFunctionMetaData.getParamTypes();
Expand Down
1 change: 1 addition & 0 deletions presto-spi/src/main/java/com/facebook/presto/spi/function/RoutineCharacteristics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public static class Language
public static final Language SQL = new Language("SQL");
public static final Language JAVA = new Language("Java");
public static final Language CPP = new Language("CPP");
public static final Language PYTHON = new Language("PYTHON");

private final String language;

Expand Down
Loading