fix(ci): Remove deprecated mac 13 runner from build tests#26952
Merged
unidevel merged 1 commit intoprestodb:masterfrom Jan 13, 2026
Merged
fix(ci): Remove deprecated mac 13 runner from build tests#26952unidevel merged 1 commit intoprestodb:masterfrom
unidevel merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the prestocpp macOS CI workflow to drop the deprecated macos-13 runner and its associated conditional build flags, standardizing the job matrix on macOS 15 only. Flow diagram for prestocpp macOS CI workflow after macos-13 removalflowchart TD
A[Workflow triggered] --> B[Evaluate changes job]
B --> C[Run prestocpp_macos_build_engine job]
C --> D[Create matrix with os macos_15]
D --> E[Run job on macos_15 runner]
E --> F[Install dependencies via brew]
F --> G[Configure environment variables]
G --> H[Run cmake with warnings_as_errors]
H --> I[Build and test prestocpp]
I --> J[Report CI status]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Given the deprecation of macOS-13, consider whether you also want explicit coverage for arm64 (e.g.,
macos-latest) in the matrix so CI continues to exercise both Intel and Apple Silicon runners. - The removal of the macOS-13-specific
CXXFLAGSsuggests the Arrow/Velox warning and macro issues are fully resolved; if they still occur on newer macOS images, it may be safer to keep those flags but make them unconditional or keyed to compiler version instead of OS.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Given the deprecation of macOS-13, consider whether you also want explicit coverage for arm64 (e.g., `macos-latest`) in the matrix so CI continues to exercise both Intel and Apple Silicon runners.
- The removal of the macOS-13-specific `CXXFLAGS` suggests the Arrow/Velox warning and macro issues are fully resolved; if they still occur on newer macOS images, it may be safer to keep those flags but make them unconditional or keyed to compiler version instead of OS.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
tdcmeehan
approved these changes
Jan 13, 2026
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The macOS-13 based runner images are being deprecated, consider switching to macOS-15 (macos-15-intel) or macOS 15 arm64 (macos-latest) instead. For more details see actions/runner-images#13046
Motivation and Context
Impact
CI
Test Plan
CI
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.