Skip to content

fix(ci): Remove deprecated mac 13 runner from build tests#26952

Merged
unidevel merged 1 commit intoprestodb:masterfrom
unidevel:mac13
Jan 13, 2026
Merged

fix(ci): Remove deprecated mac 13 runner from build tests#26952
unidevel merged 1 commit intoprestodb:masterfrom
unidevel:mac13

Conversation

@unidevel
Copy link
Copy Markdown
Contributor

Description

The macOS-13 based runner images are being deprecated, consider switching to macOS-15 (macos-15-intel) or macOS 15 arm64 (macos-latest) instead. For more details see actions/runner-images#13046

Motivation and Context

Impact

CI

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 13, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Jan 13, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the prestocpp macOS CI workflow to drop the deprecated macos-13 runner and its associated conditional build flags, standardizing the job matrix on macOS 15 only.

Flow diagram for prestocpp macOS CI workflow after macos-13 removal

flowchart TD
  A[Workflow triggered] --> B[Evaluate changes job]
  B --> C[Run prestocpp_macos_build_engine job]
  C --> D[Create matrix with os macos_15]
  D --> E[Run job on macos_15 runner]
  E --> F[Install dependencies via brew]
  F --> G[Configure environment variables]
  G --> H[Run cmake with warnings_as_errors]
  H --> I[Build and test prestocpp]
  I --> J[Report CI status]
Loading

File-Level Changes

Change Details Files
Standardize prestocpp macOS CI builds on macOS 15 and remove macOS 13-specific logic.
  • Update the prestocpp-macos-build workflow matrix to run only on macos-15 instead of both macos-13 and macos-15.
  • Remove conditional CXXFLAGS adjustments that were applied only when running on the macos-13 runner, including overrides for sign-compare and macro-redefined warnings.
.github/workflows/prestocpp-macos-build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@unidevel unidevel marked this pull request as ready for review January 13, 2026 11:07
@unidevel unidevel requested review from a team and czentgr as code owners January 13, 2026 11:07
@prestodb-ci prestodb-ci requested review from a team and sh-shamsan and removed request for a team January 13, 2026 11:07
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Given the deprecation of macOS-13, consider whether you also want explicit coverage for arm64 (e.g., macos-latest) in the matrix so CI continues to exercise both Intel and Apple Silicon runners.
  • The removal of the macOS-13-specific CXXFLAGS suggests the Arrow/Velox warning and macro issues are fully resolved; if they still occur on newer macOS images, it may be safer to keep those flags but make them unconditional or keyed to compiler version instead of OS.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Given the deprecation of macOS-13, consider whether you also want explicit coverage for arm64 (e.g., `macos-latest`) in the matrix so CI continues to exercise both Intel and Apple Silicon runners.
- The removal of the macOS-13-specific `CXXFLAGS` suggests the Arrow/Velox warning and macro issues are fully resolved; if they still occur on newer macOS images, it may be safer to keep those flags but make them unconditional or keyed to compiler version instead of OS.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@unidevel unidevel merged commit 21d8610 into prestodb:master Jan 13, 2026
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants