misc(native): Remove native-execution-enabled from e2e test worker config#26924
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Jan 8, 2026
Merged
misc(native): Remove native-execution-enabled from e2e test worker config#26924amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the now-incorrect propagation of the coordinator-only File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
tdcmeehan
pushed a commit
to rdtr/presto
that referenced
this pull request
Jan 14, 2026
…nfig (prestodb#26924) `native-execution-enabled` is a coordinator config, no need to pass it to worker config properties. Its passed to coordinator here https://github.com/prestodb/presto/blob/7e44169de44c9eb0b4509bd5b9c4b160830aa665/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/PrestoNativeQueryRunnerUtils.java#L155 ``` == NO RELEASE NOTE == ```
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
native-execution-enabledis a coordinator config, no need to pass it to worker config properties. Its passed to coordinator herepresto/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/PrestoNativeQueryRunnerUtils.java
Line 155 in 7e44169