feat(testing): Add unit tests for presto-on-spark on Spark3 profile#26914
Open
shrinidhijoshi wants to merge 1 commit intoprestodb:masterfrom
Open
feat(testing): Add unit tests for presto-on-spark on Spark3 profile#26914shrinidhijoshi wants to merge 1 commit intoprestodb:masterfrom
shrinidhijoshi wants to merge 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's GuideAdds a new GitHub Actions job to run presto-on-spark native tests against the Spark 3 profile in the prestocpp Linux workflow, parameterized by storage format and sidecar settings, including setup of dependencies, Maven install with Spark 3, and targeted test execution. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the
Run presto-on-spark native testsstep, the explicitTESTCLASSESseed list will be duplicated by the subsequentfindloop (since thoseTestPrestoSpark*.javafiles will also be discovered), so consider either relying solely on thefindoutput or deduplicating the final list before passing it to Maven. - The concurrency group name for the new job (
prestocpp-linux-presto-on-spark-e2e-tests) is missing the3present in the job name and usesgithub.event.pull_request.number, which will be unset for scheduled runs; consider aligning the group name with the job name and using a context that exists for all triggering event types (e.g.github.run_id).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the `Run presto-on-spark native tests` step, the explicit `TESTCLASSES` seed list will be duplicated by the subsequent `find` loop (since those `TestPrestoSpark*.java` files will also be discovered), so consider either relying solely on the `find` output or deduplicating the final list before passing it to Maven.
- The concurrency group name for the new job (`prestocpp-linux-presto-on-spark-e2e-tests`) is missing the `3` present in the job name and uses `github.event.pull_request.number`, which will be unset for scheduled runs; consider aligning the group name with the job name and using a context that exists for all triggering event types (e.g. `github.run_id`).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…estodb#26914) Summary: Pull Request resolved: prestodb#26914 Differential Revision: D90227666
bfc5552 to
9e1e858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D90227666