Skip to content

feat(testing): Add unit tests for presto-on-spark on Spark3 profile#26914

Open
shrinidhijoshi wants to merge 1 commit intoprestodb:masterfrom
shrinidhijoshi:export-D90227666
Open

feat(testing): Add unit tests for presto-on-spark on Spark3 profile#26914
shrinidhijoshi wants to merge 1 commit intoprestodb:masterfrom
shrinidhijoshi:export-D90227666

Conversation

@shrinidhijoshi
Copy link
Collaborator

@shrinidhijoshi shrinidhijoshi commented Jan 7, 2026

Differential Revision: D90227666

== NO RELEASE NOTES

@shrinidhijoshi shrinidhijoshi requested review from a team, czentgr and unidevel as code owners January 7, 2026 08:31
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jan 7, 2026
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 7, 2026

Reviewer's Guide

Adds a new GitHub Actions job to run presto-on-spark native tests against the Spark 3 profile in the prestocpp Linux workflow, parameterized by storage format and sidecar settings, including setup of dependencies, Maven install with Spark 3, and targeted test execution.

File-Level Changes

Change Details Files
Introduce a new CI job to run presto-on-spark native tests on Spark 3 with different storage and sidecar configurations.
  • Add prestocpp-linux-presto-on-spark3-e2e-tests job depending on code-change detection and build artifacts
  • Run the job in the prestodb/presto-native-dependency container and free runner disk space inside the container
  • Restore execute permissions for native binaries and configure library path via ldconfig
  • Install Java 17, warm Maven cache with Node.js download, and perform a Spark 3-specific Maven install for presto-native-tests
  • Discover presto-on-spark test classes and run Maven tests for presto-native-execution with Spark 3, matrixed over PARQUET/DWRF and sidecar enabled/disabled
.github/workflows/prestocpp-linux-build-and-unit-test.yml

Possibly linked issues

  • #pos Spark3 cleanup tasks: The PR adds Spark 3 presto-on-spark native CI tests, directly addressing the issue’s Spark3 test-related follow-up tasks.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@shrinidhijoshi shrinidhijoshi changed the title feat(tests): Add unit tests for presto-on-spark on Spark3 profile feat(testing): Add unit tests for presto-on-spark on Spark3 profile Jan 7, 2026
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In the Run presto-on-spark native tests step, the explicit TESTCLASSES seed list will be duplicated by the subsequent find loop (since those TestPrestoSpark*.java files will also be discovered), so consider either relying solely on the find output or deduplicating the final list before passing it to Maven.
  • The concurrency group name for the new job (prestocpp-linux-presto-on-spark-e2e-tests) is missing the 3 present in the job name and uses github.event.pull_request.number, which will be unset for scheduled runs; consider aligning the group name with the job name and using a context that exists for all triggering event types (e.g. github.run_id).
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the `Run presto-on-spark native tests` step, the explicit `TESTCLASSES` seed list will be duplicated by the subsequent `find` loop (since those `TestPrestoSpark*.java` files will also be discovered), so consider either relying solely on the `find` output or deduplicating the final list before passing it to Maven.
- The concurrency group name for the new job (`prestocpp-linux-presto-on-spark-e2e-tests`) is missing the `3` present in the job name and uses `github.event.pull_request.number`, which will be unset for scheduled runs; consider aligning the group name with the job name and using a context that exists for all triggering event types (e.g. `github.run_id`).

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants