Skip to content

fix(security): Bump transitive dependency org.apache.logging.log4j:log4j-core to 2.25.3 to fix CVE-2025-68161#26906

Merged
nishithakbhaskaran merged 1 commit intoprestodb:masterfrom
nishithakbhaskaran:log4j-core-transitive
Jan 8, 2026
Merged

fix(security): Bump transitive dependency org.apache.logging.log4j:log4j-core to 2.25.3 to fix CVE-2025-68161#26906
nishithakbhaskaran merged 1 commit intoprestodb:masterfrom
nishithakbhaskaran:log4j-core-transitive

Conversation

@nishithakbhaskaran
Copy link
Copy Markdown
Contributor

@nishithakbhaskaran nishithakbhaskaran commented Jan 6, 2026

Description

org.apache.logging.log4j:log4j-core 2.17.1 is coming into presto image transitively from presto-pinot module
which introduces the following CVE to presto .

https://nvd.nist.gov/vuln/detail/CVE-2025-68161

This PR fixes the issue by adding the vulnerable free version org.apache.logging.log4j:log4j-core 2.25.3 in dependency management.

Motivation and Context

Impact

Test Plan

image

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Security Changes
* Upgrade transitive dependency org.apache.logging.log4j:log4j-core to 2.25.3 to fix `CVE-2025-68161 <https://nvd.nist.gov/vuln/detail/CVE-2025-68161>`_.

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 6, 2026
@nishithakbhaskaran nishithakbhaskaran marked this pull request as ready for review January 6, 2026 07:09
@nishithakbhaskaran nishithakbhaskaran requested a review from a team as a code owner January 6, 2026 07:09
@prestodb-ci prestodb-ci requested review from a team, NivinCS and jp-sivaprasad and removed request for a team January 6, 2026 07:09
Copy link
Copy Markdown
Member

@agrawalreetika agrawalreetika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nishithakbhaskaran
Can you attach the details/screenshots of before and after dependency tree, how it is coming as a transitive dependency?

Also plan to run sanity integration tests for some of the queries in pinot connector as ci doesn't have pinot image.

@nishithakbhaskaran
Copy link
Copy Markdown
Contributor Author

nishithakbhaskaran commented Jan 7, 2026

Thanks for the PR @nishithakbhaskaran Can you attach the details/screenshots of before and after dependency tree, how it is coming as a transitive dependency?

Also plan to run sanity integration tests for some of the queries in pinot connector as ci doesn't have pinot image.

Below are the dependency before and after the fix.

dependency-after.txt
dependency-before.txt

It is coming as transitive dependency from org.apache.helix:helix-core:jar:1.3.1 jar

Tested pinot connector queries is updated in Test Plan

agrawalreetika
agrawalreetika previously approved these changes Jan 7, 2026
Copy link
Copy Markdown
Member

@agrawalreetika agrawalreetika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nishithakbhaskaran LGTM

Copy link
Copy Markdown
Member

@imjalpreet imjalpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that in the dependency tree shared above, we also have log4j-slf4j-impl dependency from the same group ID. Earlier both log4j-core and log4j-slf4j-impl were of the same version but now they are different. I think we could upgrade both to avoid any incompatibilities.

@nishithakbhaskaran
Copy link
Copy Markdown
Contributor Author

I see that in the dependency tree shared above, we also have log4j-slf4j-impl dependency from the same group ID. Earlier both log4j-core and log4j-slf4j-impl were of the same version but now they are different. I think we could upgrade both to avoid any incompatibilities.

@imjalpreet Thanks for the review. It sounds relevant. I could also see org.apache.logging.log4j:log4j-api:jar:2.17.1:compile.
Lets change that as well to the latest version?

[INFO] | | | +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.17.1:compile
[INFO] | | | | - org.apache.logging.log4j:log4j-api:jar:2.17.1:compile
[INFO] | | | +- org.apache.logging.log4j:log4j-core:jar:2.17.1:compile

@imjalpreet
Copy link
Copy Markdown
Member

@nishithakbhaskaran, log4j-api is coming as part of log4j-slf4j-impl, so most likely it will automatically get updated when you upgrade slf4j.

….25.3

Upgrade transitive dependency org.apache.logging.log4j:log4j-slf4j-impl to 2.25.3
@nishithakbhaskaran
Copy link
Copy Markdown
Contributor Author

@nishithakbhaskaran, log4j-api is coming as part of log4j-slf4j-impl, so most likely it will automatically get updated when you upgrade slf4j.

@imjalpreet Updated accordingly.

Copy link
Copy Markdown
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nishithakbhaskaran, looks good to me!

@nishithakbhaskaran nishithakbhaskaran merged commit 4f6969a into prestodb:master Jan 8, 2026
78 of 79 checks passed
tdcmeehan pushed a commit to rdtr/presto that referenced this pull request Jan 14, 2026
…g4j-core to 2.25.3 to fix CVE-2025-68161 (prestodb#26906)

## Description

org.apache.logging.log4j:log4j-core 2.17.1 is coming into presto image
transitively from presto-pinot module
which introduces the following CVE to presto .

https://nvd.nist.gov/vuln/detail/CVE-2025-68161

This PR fixes the issue by adding the vulnerable free version
org.apache.logging.log4j:log4j-core 2.25.3 in dependency management.

## Motivation and Context
<!---Why is this change required? What problem does it solve?-->
<!---If it fixes an open issue, please link to the issue here.-->

## Impact
<!---Describe any public API or user-facing feature change or any
performance impact-->

## Test Plan

<img width="1655" height="404" alt="image"
src="https://github.com/user-attachments/assets/c5ab7d6a-77d3-4ef6-8e5c-9dd446a4a794"
/>


## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.
- [ ] If adding new dependencies, verified they have an [OpenSSF
Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or
higher (or obtained explicit TSC approval for lower scores).

## Release Notes
Please follow [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines)
and fill in the release notes below.

```
== RELEASE NOTES ==

Security Changes
* Upgrade transitive dependency org.apache.logging.log4j:log4j-core to 2.25.3 to fix `CVE-2025-68161 <https://nvd.nist.gov/vuln/detail/CVE-2025-68161>`_.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants