fix(ci): Increase usable disk space for ci jobs#26876
Merged
czentgr merged 1 commit intoprestodb:masterfrom Dec 30, 2025
Merged
fix(ci): Increase usable disk space for ci jobs#26876czentgr merged 1 commit intoprestodb:masterfrom
czentgr merged 1 commit intoprestodb:masterfrom
Conversation
Tests are running inside the dependency container and not directly on the runner. As such we need to expand the usage of deleting unnecessary installed components from the runner.
Contributor
Reviewer's GuideUpdates the prestocpp Linux CI workflow to reclaim disk space on the GitHub runner even when jobs run inside a dependency container, by bind-mounting host directories into the container and deleting large, unused toolchains before artifacts are downloaded and tests run. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Merged
7 tasks
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
Free Disk Spacestep is duplicated across multiple jobs with identical script bodies; consider extracting this into a composite action or a reusable workflow to keep the workflow DRY and make future changes to the cleanup logic easier. - The
getAvailableSpacehelper is defined asgetAvailableSpace() { echo $(df -a $1 | ...) }but is always invoked without an argument; either remove the unused$1parameter or explicitly pass a target mount point to make the intent and output clearer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `Free Disk Space` step is duplicated across multiple jobs with identical script bodies; consider extracting this into a composite action or a reusable workflow to keep the workflow DRY and make future changes to the cleanup logic easier.
- The `getAvailableSpace` helper is defined as `getAvailableSpace() { echo $(df -a $1 | ...) }` but is always invoked without an argument; either remove the unused `$1` parameter or explicitly pass a target mount point to make the intent and output clearer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
Thank you @czentgr for unblocking landing |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are running inside the dependency container
and not directly on the runner.
As such we need to expand the usage of
deleting unnecessary installed components
from the runner.
Addresses #26864
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.