Skip to content

docs: Fix minor documentation issues #26866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hantangwangd merged 1 commit into from
Jan 9, 2026
Merged

docs: Fix minor documentation issues #26866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions presto-docs/src/main/sphinx/connector/iceberg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2379,7 +2379,7 @@ Property Name Description
The storage table inherits standard Iceberg table properties for partitioning, sorting, and file format.

Freshness and Refresh
^^^^^^^^^^^^^^^^^^^^^^
^^^^^^^^^^^^^^^^^^^^^

Materialized views track the snapshot IDs of their base tables to determine staleness. When base tables are modified, the materialized view becomes stale and returns results by querying the base tables directly. After running ``REFRESH MATERIALIZED VIEW``, queries read from the pre-computed storage table.

Expand All @@ -2388,7 +2388,7 @@ The refresh operation uses a full refresh strategy, replacing all data in the st
.. _iceberg-stale-data-handling:

Stale Data Handling
"""""""""""""""""""
^^^^^^^^^^^^^^^^^^^
Copy link
Copy Markdown
Member

@hantangwangd hantangwangd Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing: I suspect this is intentionally meant to be a sub-level. If so, since the document previously defined ~~~~~~ as the sub-level of ^^^^^^, should we use ~~~~~~ here for level consistency? cc: @tdcmeehan

Copy link
Copy Markdown
Contributor

@steveburnett steveburnett Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing: I suspect this is intentionally meant to be a sub-level. If so, since the document previously defined ~~~~~~ as the sub-level of ^^^^^^, should we use ~~~~~~ here for level consistency? cc: @tdcmeehan

@hantangwangd, I think that this Stale Data Handling is a subheading of Materialized Views so I think this change is okay. On the other hand, if Stale Data Handling is intended as a subheading of Freshness and Refresh, then I would agree with you.

Copy link
Copy Markdown
Contributor

@tdcmeehan tdcmeehan Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I had intended this to be a sub-heading for Materialized Views, however if we think this should go under Freshness and Refresh I am fine with that too.

Copy link
Copy Markdown
Contributor

@steveburnett steveburnett Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Materialized Views

Thanks @tdcmeehan! This PR sets the Stale Data Handling heading as a subheading of Materialized Views. I don't see a strong reason in the text that this should be changed to be a subheading of Freshness and Refresh.

Copy link
Copy Markdown
Member

@hantangwangd hantangwangd Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback and confirmation @tdcmeehan, @steveburnett. I'm completely okey with treating it as a subheading of Materialized Views.


By default, when no staleness properties are configured, queries against a stale materialized
view will fall back to executing the underlying view query against the base tables. You can
Expand Down
2 changes: 1 addition & 1 deletion presto-docs/src/main/sphinx/develop/procedures.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ During startup, the PrestoDB engine collects the procedure providers exposed by
respective namespaces (for example, ``hive.system`` or ``iceberg.system``). Once startup is complete, users can invoke these procedures by specifying
the corresponding connector namespace, for example:

.. code-block:: java
.. code-block:: sql

call iceberg.system.expire_snapshots('default', 'test_table');
call hive.system.invalidate_directory_list_cache();
Expand Down
2 changes: 1 addition & 1 deletion presto-docs/src/main/sphinx/plugin/native-sidecar-plugin.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ Property Name Description
============================================ ===================================================================== ==============================

Expression optimizer
-----------------
--------------------

These properties must be configured in ``etc/expression-manager/native.properties`` to use the native expression optimizer of the ``NativeSidecarPlugin``.

Expand Down
6 changes: 3 additions & 3 deletions presto-docs/src/main/sphinx/presto_cpp/features.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,23 +55,23 @@ The request/response flow of Presto C++ is identical to Java workers. The tasks

* GET: /v1/operation/server/clearCache?type=memory: It clears the memory cache on worker node. Here is an example:

.. sourcecode:: http
.. code-block:: shell

curl -X GET "http://localhost:7777/v1/operation/server/clearCache?type=memory"

Cleared memory cache

* GET: /v1/operation/server/clearCache?type=ssd: It clears the ssd cache on worker node. Here is an example:

.. sourcecode:: http
.. code-block:: shell

curl -X GET "http://localhost:7777/v1/operation/server/clearCache?type=ssd"

Cleared ssd cache

* GET: /v1/operation/server/writeSsd: It writes data from memory cache to the ssd cache on worker node. Here is an example:

.. sourcecode:: http
.. code-block:: shell

curl -X GET "http://localhost:7777/v1/operation/server/writeSsd"

Expand Down
Loading