build(native): Add dependency on Apache DataSketches CPP for Sketch Theta functions#26831
Merged
aditi-pandit merged 1 commit intoprestodb:masterfrom Jan 9, 2026
Conversation
Contributor
|
🧙 Sourcery is reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Joe-Abraham
previously approved these changes
Dec 19, 2025
Contributor
Joe-Abraham
left a comment
There was a problem hiding this comment.
LGTM, Thanks @nmahadevuni
czentgr
reviewed
Jan 2, 2026
Contributor
czentgr
left a comment
There was a problem hiding this comment.
Thanks, only a minor comment.
NOTICES
Outdated
|
|
||
| Prior to moving to ASF, the software for this project was developed at | ||
| Yahoo Inc. (https://developer.yahoo.com). | ||
| ------- No newline at end of file |
Member
Author
There was a problem hiding this comment.
Addressed this comment. Please approve.
8e2aaf4 to
703fae5
Compare
Member
Author
|
@czentgr CI passed. Please approve. |
czentgr
approved these changes
Jan 8, 2026
aditi-pandit
approved these changes
Jan 9, 2026
Contributor
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks @nmahadevuni and @czentgr
tdcmeehan
approved these changes
Jan 9, 2026
tdcmeehan
pushed a commit
to rdtr/presto
that referenced
this pull request
Jan 14, 2026
…heta functions (prestodb#26831) ## Description This change adds a Apache DataSketches CPP package to the setup scripts ## Motivation and Context This package is required to implement Theta sketch aggregate and scalar functions required for Iceberg statistics. The functions will be implemented in a different PR prestodb#25685 . ## Impact No impact ## Test Plan <!---Please fill in how you tested your change--> ``` == NO RELEASE NOTE == ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a Apache DataSketches CPP package to the setup scripts
Motivation and Context
This package is required to implement Theta sketch aggregate and scalar functions required for Iceberg statistics. The functions will be implemented in a different PR #25685 .
Impact
No impact
Test Plan