feat: Support both Spark2.4 and Spark3.4 in one module#26729
feat: Support both Spark2.4 and Spark3.4 in one module#26729wangkewen wants to merge 1 commit intoprestodb:masterfrom
Conversation
cf3d042 to
ab51efc
Compare
|
Thanks for getting started on this @wangkewen . It looks like there we might have to fix the destination directory path from |
shrinidhijoshi
left a comment
There was a problem hiding this comment.
Thanks for making changes. Left some comments
yeah, updated. |
2af8fff to
301453d
Compare
|
@wangkewen Please rebase. The CI test issues should be resolved now. |
301453d to
ac7e4d5
Compare
…er-interface Delete two modules presto-spark-classloader-spark2 and presto-spark-classloader-spark3 in the previous approach to support both Spark2 and Spark3. Move the previous implementations into subdirs into existing module presto-spark-classloader-interface. Clean up dependencies in pom files of root, presto-spark-base and presto-spark-launcher.
ac7e4d5 to
a8bcbe1
Compare
|
@wangkewen can you please rebase again to fix up the CI. We need this before we can cut the release. |
|
@wangkewen when you can, please rebase to re-run and hopefully pass the CI checks. This PR is needed for the next release of Presto. |
Description
Previous approach (#25552) supporting both Spark2.4 and Spark3.4 utilizes two separate modules which incurred some release inconsistence issues. This change merges this change into existing module without generating separate modules.
Motivation and Context
It tries to resolve one issue mentioned here #25833.
Impact
Test Plan
Build for Spark2
Build for Spark3
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: