Skip to content

misc: Add lookup cast in standard function resolution #26657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feilong-liu merged 1 commit into from
Nov 20, 2025
Merged

misc: Add lookup cast in standard function resolution #26657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions presto-main-base/src/main/java/com/facebook/presto/sql/relational/FunctionResolution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,12 @@ public boolean isCastFunction(FunctionHandle functionHandle)
return functionAndTypeResolver.getFunctionMetadata(functionHandle).getOperatorType().equals(Optional.of(OperatorType.CAST));
}

@Override
public FunctionHandle lookupCast(String castType, Type fromType, Type toType)
{
return functionAndTypeResolver.lookupCast(castType, fromType, toType);
}

public boolean isTryCastFunction(FunctionHandle functionHandle)
{
return functionAndTypeResolver.getFunctionMetadata(functionHandle).getName().equals(QualifiedObjectName.valueOf(JAVA_BUILTIN_NAMESPACE, "TRY_CAST"));
Expand Down
4 changes: 4 additions & 0 deletions ...to-main-base/src/test/java/com/facebook/presto/sql/relational/TestFunctionResolution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import static com.facebook.presto.common.type.BooleanType.BOOLEAN;
import static com.facebook.presto.common.type.DoubleType.DOUBLE;
import static com.facebook.presto.common.type.TypeSignature.parseTypeSignature;
import static com.facebook.presto.common.type.VarcharType.VARCHAR;
import static com.facebook.presto.metadata.FunctionAndTypeManager.createTestFunctionAndTypeManager;
import static com.facebook.presto.spi.function.FunctionImplementationType.THRIFT;
import static com.facebook.presto.spi.function.FunctionVersion.notVersioned;
Expand Down Expand Up @@ -96,6 +97,9 @@ public void testStandardFunctionResolution()
// full qualified name
assertEquals(standardFunctionResolution.notFunction(), standardFunctionResolution.lookupFunction("presto", "default", "not", ImmutableList.of(BOOLEAN)));
assertEquals(standardFunctionResolution.countFunction(), standardFunctionResolution.lookupFunction("presto", "default", "count", ImmutableList.of()));

// lookup cast
assertTrue(standardFunctionResolution.isCastFunction(standardFunctionResolution.lookupCast("CAST", BIGINT, VARCHAR)));
}

@Test
Expand Down
2 changes: 2 additions & 0 deletions presto-spi/src/main/java/com/facebook/presto/spi/function/StandardFunctionResolution.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ public interface StandardFunctionResolution

boolean isCastFunction(FunctionHandle functionHandle);

FunctionHandle lookupCast(String castType, Type fromType, Type toType);

boolean isCountFunction(FunctionHandle functionHandle);

boolean isCountIfFunction(FunctionHandle functionHandle);
Expand Down
Loading