chore: Upgrade org.locationtech.jts version to 1.20.0#26646
Merged
nishithakbhaskaran merged 1 commit intoprestodb:masterfrom Jan 27, 2026
Merged
chore: Upgrade org.locationtech.jts version to 1.20.0#26646nishithakbhaskaran merged 1 commit intoprestodb:masterfrom
nishithakbhaskaran merged 1 commit intoprestodb:masterfrom
Conversation
272fb32 to
1d747a8
Compare
1d747a8 to
34c960f
Compare
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgrades the org.locationtech.jts dependency to 1.20.0 and aligns geospatial geometry validation tests with updated JTS error messages. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The tests that assert exact JTS error strings (e.g., "Ring Self-intersection" vs "Self-intersection") are tightly coupled to the library’s internal messages; consider relaxing these to check for a stable substring or error type so future JTS updates don’t require test rewrites for wording changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tests that assert exact JTS error strings (e.g., "Ring Self-intersection" vs "Self-intersection") are tightly coupled to the library’s internal messages; consider relaxing these to check for a stable substring or error type so future JTS updates don’t require test rewrites for wording changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
agrawalreetika
left a comment
There was a problem hiding this comment.
Lgtm, just have one question
| assertInvalidReason("POLYGON ((0 0, 0 1, 1 1, 1 0, 0 0), (0 1, 1 1, 0.5 0.5, 0 1))", "Self-intersection"); | ||
| assertInvalidReason("POLYGON ((0 0, 0 1, 1 1, 1 0, 0 0), (0 0, 0.5 0.7, 1 1, 0.5 0.4, 0 0))", "Interior is disconnected"); | ||
| assertInvalidReason("POLYGON ((0 0, -1 0.5, 0 1, 1 1, 1 0, 0 1, 0 0))", "Ring Self-intersection"); | ||
| assertInvalidReason("MULTIPOLYGON (((0 0, 0 1, 1 1, 1 0, 0 0)), ((0.5 0.5, 0.5 2, 2 2, 2 0.5, 0.5 0.5)))", "Self-intersection"); | ||
| assertInvalidReason("GEOMETRYCOLLECTION (POINT (1 2), POLYGON ((0 0, 0 1, 2 1, 1 1, 1 0, 0 0)))", "Ring Self-intersection"); | ||
| assertInvalidReason("GEOMETRYCOLLECTION (POINT (1 2), POLYGON ((0 0, 0 1, 2 1, 1 1, 1 0, 0 0)))", "Self-intersection"); |
Member
There was a problem hiding this comment.
Do we know what changed in tests after upgrade?
Contributor
Author
There was a problem hiding this comment.
Before (1.19.0): "Ring Self-intersection" - Used for all polygon ring self-intersections
After (1.20.0): "Self-intersection" - Used for certain types of polygon self-intersections
Still Returns "Ring Self-intersection": Complex ring intersections involving multiple segments
agrawalreetika
approved these changes
Jan 16, 2026
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade org.locationtech.jts version to 1.20.0
Motivation and Context
Using a more recent version helps avoid potential vulnerabilities and ensures we aren't relying on outdated or unsupported code.
Impact
Test Plan
Contributor checklist