chore: Upgrade io.opentelemetry version to 1.58.0 by sumi-mathew · Pull Request #26644 · prestodb/presto

sumi-mathew · 2025-11-18T06:11:47Z

Description

Upgrade io.opentelemetry version to 1.58.0

Motivation and Context

Using a more recent version helps avoid potential vulnerabilities and ensures we aren't relying on outdated or unsupported code.

Impact

Test Plan

Contributor checklist

Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.
If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

BryanCutler

LGTM

imjalpreet

Thanks, @sumi-mathew.

I don't see any tests present in the open-telemetry plugin. It would be good to at least manually test out the plugin to ensure that everything is working since expected since we are moving from 1.19.0(released in 2022) to 1.56.0(released last month).

imjalpreet · 2025-12-01T22:22:30Z

pom.xml

            <dependency>
                <groupId>io.opentelemetry</groupId>
                <artifactId>opentelemetry-semconv</artifactId>
-                <version>1.19.0-alpha</version>
+                <version>1.30.1-alpha</version>


It looks like this dependency has moved to https://mvnrepository.com/artifact/io.opentelemetry.semconv/opentelemetry-semconv, and there are more recent versions released.

Thanks for reviewing this PR. I have tested the changes and am attaching the test results.

sumi-mathew · 2026-01-27T06:40:58Z

@imjalpreet Could you please re-review the PR

agrawalreetika

Thanks for the changes. I have just one comment

agrawalreetika · 2026-01-27T18:28:10Z

pom.xml

        <dep.fastutil.version>8.5.2</dep.fastutil.version>
        <dep.datasketches-memory.version>2.2.0</dep.datasketches-memory.version>
        <dep.datasketches-java.version>5.0.1</dep.datasketches-java.version>
+        <dep.io.opentelemetry.version>1.56.0</dep.io.opentelemetry.version>


Why don't we upgrade to the latest 1.58.0 version?

At the time of raising the PR, the latest version was 1.56.0. I’ve now updated it to 1.58.0.

agrawalreetika

LGTM

imjalpreet

Thanks, @sumi-mathew.

LGTM % one small recommendation.

imjalpreet · 2026-01-28T18:36:32Z

presto-open-telemetry/src/main/java/com/facebook/presto/opentelemetry/OpenTelemetryBuilder.java

    {
        Resource resource = Resource.getDefault()
-                .merge(Resource.create(Attributes.of(ResourceAttributes.SERVICE_NAME, "presto")));
+                .merge(Resource.create(Attributes.of(AttributeKey.stringKey("service.name"), "presto")));


ResourceAttributes was deprecated and removed, but SERVICE_NAME was moved to ServiceAttributes: https://github.com/open-telemetry/semantic-conventions-java/blob/release/v1.37.0/semconv/src/main/java/io/opentelemetry/semconv/ServiceAttributes.java

Let's migrate to this rather than using a hardcoded value in Presto.

Thanks for pointing this out. I’ve migrated to ServiceAttributes as suggested and removed the hardcoded value from Presto.

imjalpreet

LGTM. Thanks, @sumi-mathew.

hantangwangd

Thanks @sumi-mathew

prestodb-ci added the from:IBM PR from IBM label Nov 18, 2025

sumi-mathew force-pushed the upgrade_opentelemetry branch from 9e4c1ff to 6fb33bb Compare November 20, 2025 07:10

sumi-mathew changed the title ~~Upgrade io.opentelemetry version to 1.56.0~~ chore: Upgrade io.opentelemetry version to 1.56.0 Nov 20, 2025

sumi-mathew marked this pull request as ready for review November 20, 2025 10:31

sumi-mathew requested a review from a team as a code owner November 20, 2025 10:31

prestodb-ci requested review from a team, BryanCutler and imjalpreet and removed request for a team November 20, 2025 10:31

Mariamalmesfer approved these changes Nov 27, 2025

View reviewed changes

BryanCutler previously approved these changes Dec 1, 2025

View reviewed changes

imjalpreet reviewed Dec 1, 2025

View reviewed changes

sumi-mathew dismissed BryanCutler’s stale review via 163a0c0 January 15, 2026 06:37

sumi-mathew force-pushed the upgrade_opentelemetry branch from bc77898 to 81b04da Compare January 15, 2026 09:46

sumi-mathew requested a review from imjalpreet January 15, 2026 11:07

agrawalreetika reviewed Jan 27, 2026

View reviewed changes

sumi-mathew force-pushed the upgrade_opentelemetry branch from 81b04da to 15f2f3a Compare January 28, 2026 09:22

sumi-mathew changed the title ~~chore: Upgrade io.opentelemetry version to 1.56.0~~ chore: Upgrade io.opentelemetry version to 1.58.0 Jan 28, 2026

agrawalreetika previously approved these changes Jan 28, 2026

View reviewed changes

imjalpreet requested changes Jan 28, 2026

View reviewed changes

Upgrade io.opentelemetry version to 1.58.0

e4d76be

sumi-mathew dismissed agrawalreetika’s stale review via e4d76be January 29, 2026 05:18

sumi-mathew force-pushed the upgrade_opentelemetry branch from 15f2f3a to e4d76be Compare January 29, 2026 05:18

sumi-mathew requested a review from imjalpreet January 29, 2026 05:22

imjalpreet approved these changes Jan 29, 2026

View reviewed changes

hantangwangd approved these changes Jan 29, 2026

View reviewed changes

imjalpreet merged commit 1a67c8e into prestodb:master Jan 29, 2026
80 checks passed

This was referenced Mar 31, 2026

docs: Add release notes for 0.297 unix280/presto#51

Closed

docs: Add release notes for 0.297 unix280/presto#52

Open

prestodb-ci mentioned this pull request Apr 1, 2026

docs: Add release notes for 0.297 #27484

Open

15 tasks

Conversation

sumi-mathew commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

Uh oh!

BryanCutler left a comment

Choose a reason for hiding this comment

Uh oh!

imjalpreet left a comment

Choose a reason for hiding this comment

Uh oh!

imjalpreet Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

sumi-mathew Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

sumi-mathew commented Jan 27, 2026

Uh oh!

agrawalreetika left a comment

Choose a reason for hiding this comment

Uh oh!

agrawalreetika Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

sumi-mathew Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

agrawalreetika left a comment

Choose a reason for hiding this comment

Uh oh!

imjalpreet left a comment

Choose a reason for hiding this comment

Uh oh!

imjalpreet Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

sumi-mathew Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

imjalpreet left a comment

Choose a reason for hiding this comment

Uh oh!

hantangwangd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sumi-mathew commented Nov 18, 2025 •

edited

Loading