[do not merge] testing pr

[zation99]

Differential Revision: D87036805

[sourcery-ai]

Reviewer's Guide

Refactor materialized view handling in StatementAnalyzer by separating data‐consistency and non‐consistency paths, centralizing recursion checks, and adding permission enforcement with on‐the‐fly view query processing when consistency is disabled.

Sequence diagram for materialized view handling in StatementAnalyzer

sequenceDiagram
    participant Session
    participant StatementAnalyzer
    participant Analysis
    participant MaterializedView
    participant AccessControlReferences
    participant SqlParser
    participant WarningCollector

    Session->>StatementAnalyzer: visitTable(table, scope)
    StatementAnalyzer->>Analysis: getStatement()
    StatementAnalyzer->>Analysis: getMaterializedViewAnalysisState(table)
    alt Data consistency enabled
        StatementAnalyzer->>MaterializedView: processMaterializedView(table, name, scope, materializedView)
        Note over StatementAnalyzer,MaterializedView: If not visited
        StatementAnalyzer->>StatementAnalyzer: throw SemanticException if recursive
    else Data consistency disabled
        StatementAnalyzer->>AccessControlReferences: addMaterializedViewDefinitionReference(name, materializedViewDefinition)
        StatementAnalyzer->>SqlParser: createStatement(materializedViewDefinition.getOriginalSql(), parsingOptions)
        StatementAnalyzer->>Analysis: registerMaterializedViewForAnalysis(name, table, originalSql)
        StatementAnalyzer->>StatementAnalyzer: process(viewQuery, scope)
        StatementAnalyzer->>Analysis: unregisterMaterializedViewForAnalysis(table)
    end

Loading

Class diagram for updated materialized view analysis in StatementAnalyzer

classDiagram
    class StatementAnalyzer {
        +visitTable(table, scope)
        +processMaterializedView(table, name, scope, materializedView)
        +process(viewQuery, scope)
    }
    class Analysis {
        +getStatement()
        +getMaterializedViewAnalysisState(table)
        +registerMaterializedViewForAnalysis(name, table, originalSql)
        +unregisterMaterializedViewForAnalysis(table)
        +getAccessControlReferences()
    }
    class MaterializedViewAnalysisState {
        +isNotVisited()
        +isVisited()
    }
    class AccessControlReferences {
        +addMaterializedViewDefinitionReference(name, materializedViewDefinition)
    }
    class MaterializedViewDefinition {
        +getOriginalSql()
    }
    class SqlParser {
        +createStatement(sql, parsingOptions)
    }
    class Query {}
    class WarningCollector {}

    StatementAnalyzer --> Analysis
    StatementAnalyzer --> SqlParser
    StatementAnalyzer --> MaterializedViewAnalysisState
    StatementAnalyzer --> AccessControlReferences
    StatementAnalyzer --> MaterializedViewDefinition
    StatementAnalyzer --> Query
    StatementAnalyzer --> WarningCollector
    Analysis --> AccessControlReferences
    Analysis --> MaterializedViewAnalysisState
    MaterializedViewDefinition --> SqlParser

Loading

Flow diagram for materialized view decision logic in StatementAnalyzer

flowchart TD
    A["visitTable(table, scope)"] --> B{Is materialized view present?}
    B -- No --> C["Proceed as table"]
    B -- Yes --> D{Is statement a Query?}
    D -- No --> C
    D -- Yes --> E{Is data consistency enabled?}
    E -- Yes --> F["Get MaterializedViewAnalysisState"]
    F --> G{isNotVisited?}
    G -- Yes --> H["processMaterializedView"]
    G -- No --> I{isVisited?}
    I -- Yes --> J["Throw SemanticException (recursive)"]
    I -- No --> C
    E -- No --> K["Add permission reference"]
    K --> L["Parse original SQL"]
    L --> M["Register for analysis"]
    M --> N["Process viewQuery"]
    N --> O["Unregister from analysis"]

Loading

File-Level Changes

Change	Details	Files
Refactor conditional structure for materialized view processing	Removed combined data consistency and presence check from outer if Introduced nested if (data consistency enabled) inside presence+Query check Relocated recursive materialized view exception alongside isNotVisited check	presto-main-base/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java
Add support for permission checks and view query processing when data consistency is disabled	Add materialized view definition reference to access control Parse original SQL into a Query using sqlParser Register and unregister materialized view for analysis and process the view query	presto-main-base/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}