fix(native): Fix a flaky test in FunctionMetadataTest#26528
Closed
xin-zhang2 wants to merge 1 commit intoprestodb:masterfrom
Closed
fix(native): Fix a flaky test in FunctionMetadataTest#26528xin-zhang2 wants to merge 1 commit intoprestodb:masterfrom
xin-zhang2 wants to merge 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnsure deterministic ordering of nested variable constraints in FunctionMetadataTest by sorting JSON sub-arrays before comparison, eliminating flakiness due to unordered_map iteration. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
Author
|
Close as duplicate of #26441. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a flaky test FunctionMetadataTest.mod(#26527).
longVariableConstraintsis built ingetLongVariableConstraints, and its element order depends on the iterating of functionSignature.variables(), which is an unordered_map and therefore not guaranteed.This PR adds a sort operation before the result comparison.
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.