Skip to content

fix(native): Fix a flaky test in FunctionMetadataTest#26528

Closed
xin-zhang2 wants to merge 1 commit intoprestodb:masterfrom
xin-zhang2:fixFunctionMetadataTest
Closed

fix(native): Fix a flaky test in FunctionMetadataTest#26528
xin-zhang2 wants to merge 1 commit intoprestodb:masterfrom
xin-zhang2:fixFunctionMetadataTest

Conversation

@xin-zhang2
Copy link
Contributor

@xin-zhang2 xin-zhang2 commented Nov 4, 2025

Description

This PR fixes a flaky test FunctionMetadataTest.mod(#26527).

presto-native-execution/presto_cpp/main/functions/tests/FunctionMetadataTest.cpp:74: Failure
Expected equality of these values:
   expectedList[i]
     Which is: {"docString":"presto.default.mod","functionKind":"SCALAR","longVariableConstraints":[{"expression":"max(i5, i6)","name":"i7"},{"expression":"min(i2 - i6, i1 - i5) + max(i5, i6)","name":"i3"}],"outputType":"decimal(i3,i7)","paramTypes":["decimal(i1,i5)","decimal(i2,i6)"],"routineCharacteristics":{"determinism":"DETERMINISTIC","language":"CPP","nullCallClause":"RETURNS_NULL_ON_NULL_INPUT"},"schema":"default","typeVariableConstraints":[],"variableArity":false}
   metadataList[i]
     Which is: {"docString":"presto.default.mod","functionKind":"SCALAR","longVariableConstraints":[{"expression":"min(i2 - i6, i1 - i5) + max(i5, i6)","name":"i3"},{"expression":"max(i5, i6)","name":"i7"}],"outputType":"decimal(i3,i7)","paramTypes":["decimal(i1,i5)","decimal(i2,i6)"],"routineCharacteristics":{"determinism":"DETERMINISTIC","language":"CPP","nullCallClause":"RETURNS_NULL_ON_NULL_INPUT"},"schema":"default","typeVariableConstraints":[],"variableArity":false}
 Position: 1

longVariableConstraints is built in getLongVariableConstraints, and its element order depends on the iterating of functionSignature.variables(), which is an unordered_map and therefore not guaranteed.
This PR adds a sort operation before the result comparison.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@xin-zhang2 xin-zhang2 requested review from a team as code owners November 4, 2025 18:26
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Nov 4, 2025
@prestodb-ci prestodb-ci requested review from a team, Mariamalmesfer and jkhaliqi and removed request for a team November 4, 2025 18:26
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 4, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensure deterministic ordering of nested variable constraints in FunctionMetadataTest by sorting JSON sub-arrays before comparison, eliminating flakiness due to unordered_map iteration.

File-Level Changes

Change Details Files
Introduce deterministic sorting of nested variable constraint arrays in the test
  • Add sortVariableConstraints lambda to sort 'longVariableConstraints' and 'typeVariableConstraints' by their 'name' field
  • Call sortVariableConstraints on both expectedList[i] and metadataList[i] before each EXPECT_EQ assertion
presto-native-execution/presto_cpp/main/functions/tests/FunctionMetadataTest.cpp

Possibly linked issues

  • #unknown: The PR fixes the flaky FunctionMetadataTest.mod by adding a sort operation for longVariableConstraints as described in the issue.
  • Add release notes for 0.217 #12345: The PR adds a sort operation for longVariableConstraints to fix the flaky FunctionMetadataTest.mod caused by unordered map iteration.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@xin-zhang2
Copy link
Contributor Author

Close as duplicate of #26441.

@xin-zhang2 xin-zhang2 closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants