Skip to content

feat: Add queryType to ConnectorSession to send query meta information #26474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singcha merged 1 commit into from
Nov 13, 2025
Merged

feat: Add queryType to ConnectorSession to send query meta information #26474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions presto-hive/src/test/java/com/facebook/presto/hive/AbstractTestHiveClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import com.facebook.presto.common.predicate.Range;
import com.facebook.presto.common.predicate.TupleDomain;
import com.facebook.presto.common.predicate.ValueSet;
import com.facebook.presto.common.resourceGroups.QueryType;
import com.facebook.presto.common.type.ArrayType;
import com.facebook.presto.common.type.MapType;
import com.facebook.presto.common.type.NamedTypeSignature;
Expand Down Expand Up @@ -1250,6 +1251,12 @@ public RuntimeStats getRuntimeStats()
return session.getRuntimeStats();
}

@Override
public Optional<QueryType> getQueryType()
{
return session.getQueryType();
}

@Override
public ConnectorSession forConnectorId(ConnectorId connectorId)
{
Expand Down
7 changes: 7 additions & 0 deletions presto-main-base/src/main/java/com/facebook/presto/FullConnectorSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import com.facebook.presto.common.RuntimeStats;
import com.facebook.presto.common.function.SqlFunctionProperties;
import com.facebook.presto.common.resourceGroups.QueryType;
import com.facebook.presto.common.type.TimeZoneKey;
import com.facebook.presto.metadata.SessionPropertyManager;
import com.facebook.presto.spi.ConnectorId;
Expand Down Expand Up @@ -309,6 +310,12 @@ public RuntimeStats getRuntimeStats()
return runtimeStats;
}

@Override
public Optional<QueryType> getQueryType()
{
return session.getQueryType();
}

@Override
public ConnectorSession forConnectorId(ConnectorId connectorId)
{
Expand Down
7 changes: 7 additions & 0 deletions presto-main-base/src/main/java/com/facebook/presto/testing/TestingConnectorSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import com.facebook.presto.FullConnectorSession;
import com.facebook.presto.common.RuntimeStats;
import com.facebook.presto.common.function.SqlFunctionProperties;
import com.facebook.presto.common.resourceGroups.QueryType;
import com.facebook.presto.common.type.TimeZoneKey;
import com.facebook.presto.execution.QueryIdGenerator;
import com.facebook.presto.spi.ConnectorId;
Expand Down Expand Up @@ -228,6 +229,12 @@ public RuntimeStats getRuntimeStats()
return new RuntimeStats();
}

@Override
public Optional<QueryType> getQueryType()
{
return Optional.of(QueryType.SELECT);
}

@Override
public ConnectorSession forConnectorId(ConnectorId connectorId)
{
Expand Down
3 changes: 3 additions & 0 deletions presto-spi/src/main/java/com/facebook/presto/spi/ConnectorSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import com.facebook.presto.common.RuntimeStats;
import com.facebook.presto.common.function.SqlFunctionProperties;
import com.facebook.presto.common.resourceGroups.QueryType;
import com.facebook.presto.common.type.TimeZoneKey;
import com.facebook.presto.spi.function.SqlFunctionId;
import com.facebook.presto.spi.function.SqlInvokedFunction;
Expand Down Expand Up @@ -67,6 +68,8 @@ default boolean isReadConstraints()

RuntimeStats getRuntimeStats();

Optional<QueryType> getQueryType();
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Documenting the semantics of getQueryType() could help future maintainers.

Clarifying the expected values and conditions for returning Optional.empty would make the method's behavior more transparent.

Suggested change
Optional<QueryType> getQueryType();
/**
* Returns the {@link QueryType} for the current session, if available.
* <p>
* The returned {@link Optional} will contain a value if the query type is known
* (e.g., for queries submitted via the main Presto engine). If the query type cannot
* be determined (such as for internal or system queries), {@link Optional#empty()} is returned.
*
* @return an {@link Optional} containing the {@link QueryType} if available, otherwise {@link Optional#empty()}
*/
Optional<QueryType> getQueryType();


/**
* returns a ConnectorSession for a specific ConnectorId
* @return
Expand Down
7 changes: 7 additions & 0 deletions presto-spi/src/test/java/com/facebook/presto/spi/TestingSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import com.facebook.presto.common.RuntimeStats;
import com.facebook.presto.common.function.SqlFunctionProperties;
import com.facebook.presto.common.resourceGroups.QueryType;
import com.facebook.presto.common.type.TimeZoneKey;
import com.facebook.presto.spi.function.SqlFunctionId;
import com.facebook.presto.spi.function.SqlInvokedFunction;
Expand Down Expand Up @@ -131,6 +132,12 @@ public RuntimeStats getRuntimeStats()
return new RuntimeStats();
}

@Override
public Optional<QueryType> getQueryType()
{
return Optional.of(QueryType.SELECT);
}

@Override
public ConnectorSession forConnectorId(ConnectorId connectorId)
{
Expand Down
Loading