Skip to content

misc: Add get connector ID for connector session #26431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feilong-liu merged 1 commit into from
Oct 25, 2025
Merged

misc: Add get connector ID for connector session #26431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions presto-main-base/src/main/java/com/facebook/presto/FullConnectorSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,12 @@ public Optional<String> getSchema()
return session.getSchema();
}

@Override
public Optional<ConnectorId> getConnectorId()
{
return Optional.ofNullable(connectorId);
}

@Override
public boolean isReadConstraints()
{
Expand Down
5 changes: 4 additions & 1 deletion ...c/main/java/com/facebook/presto/sql/planner/optimizations/ApplyConnectorOptimization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.facebook.presto.SystemSessionProperties;
import com.facebook.presto.spi.ConnectorId;
import com.facebook.presto.spi.ConnectorPlanOptimizer;
import com.facebook.presto.spi.ConnectorSession;
import com.facebook.presto.spi.VariableAllocator;
import com.facebook.presto.spi.WarningCollector;
import com.facebook.presto.spi.plan.AggregationNode;
Expand Down Expand Up @@ -183,7 +184,9 @@ public PlanOptimizerResult optimize(PlanNode plan, Session session, TypeProvider
// the returned node is still a max closure (only if there is no new connector added, which does happen but ignored here)
for (ConnectorPlanOptimizer optimizer : entry.getValue()) {
long start = System.nanoTime();
newNode = optimizer.optimize(newNode, session.toConnectorSession(connectorId), variableAllocator, idAllocator);
ConnectorSession connectorSession = session.toConnectorSession(connectorId);
checkState(connectorSession.getConnectorId().isPresent());
Copy link
Copy Markdown
Contributor Author

@feilong-liu feilong-liu Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that connector ID is available in connector optimizer

newNode = optimizer.optimize(newNode, connectorSession, variableAllocator, idAllocator);
if (enableVerboseRuntimeStats || trackOptimizerRuntime(session, optimizer)) {
session.getRuntimeStats().addMetricValue(String.format("optimizer%sTimeNanos", getOptimizerNameForLog(optimizer)), NANO, System.nanoTime() - start);
}
Expand Down
5 changes: 5 additions & 0 deletions presto-spi/src/main/java/com/facebook/presto/spi/ConnectorSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,9 @@ default boolean isReadConstraints()
* @return
*/
ConnectorSession forConnectorId(ConnectorId connectorId);

default Optional<ConnectorId> getConnectorId()
{
return Optional.empty();
}
}
Loading