Skip to content

fix(ui): Fix timeline and stage detail #26402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yhwang merged 2 commits into from
Oct 27, 2025
Merged

fix(ui): Fix timeline and stage detail #26402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d52107
fix(ui): fix timeline and stage detail
wanweitao Oct 22, 2025
69f367c
fix(ui): remove unnecessary parsing
wanweitao Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-ui/src/components/QueryDetail.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function TaskList({tasks}) {
function calculateElapsedTime(row) {
let elapsedTime = parseDuration(row.stats.elapsedTimeInNanos + "ns");
if (elapsedTime === 0) {
elapsedTime = Date.now() - Date.parse(row.stats.createTime);
elapsedTime = Date.now() - row.stats.createTimeInMillis;
}
return elapsedTime;
}
Expand Down
4 changes: 2 additions & 2 deletions presto-ui/src/components/QueryOverview.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ type TaskStatus = {
}

type TaskStats = {
createTime: string;
createTimeInMillis: number;
elapsedTimeInNanos: number;
totalCpuTimeInNanos: number;
fullyBlocked: boolean;
Expand Down Expand Up @@ -285,7 +285,7 @@ function TaskList({ tasks }: { tasks: Task[] }) : React.Node {
function calculateElapsedTime(row: Task): number {
let elapsedTime = parseDuration(row.stats.elapsedTimeInNanos + "ns") || 0;
if (elapsedTime === 0) {
elapsedTime = Date.now() - Date.parse(row.stats.createTime);
elapsedTime = Date.now() - row.stats.createTimeInMillis;
}
return elapsedTime;
}
Expand Down
10 changes: 5 additions & 5 deletions presto-ui/src/components/QuerySplitsView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ export default function SplitView({ data, show }): void {
return {
taskId: task.taskId.substring(task.taskId.indexOf('.') + 1),
time: {
create: task.stats.createTime,
firstStart: task.stats.firstStartTime,
lastStart: task.stats.lastStartTime,
lastEnd: task.stats.lastEndTime,
end: task.stats.endTime,
create: task.stats.createTimeInMillis,
firstStart: task.stats.firstStartTimeInMillis,
lastStart: task.stats.lastStartTimeInMillis,
lastEnd: task.stats.lastEndTimeInMillis,
end: task.stats.endTimeInMillis,
},
};
});
Expand Down
6 changes: 3 additions & 3 deletions presto-ui/src/components/QueryStageView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,9 @@ function OperatorDetail({ index, operator, tasks }) {
tasksSorted.forEach(task => {
task.stats.pipelines.forEach(pipeline => {
if (pipeline.pipelineId === operator.pipelineId) {
pipeline.operatorSummaries.forEach(operator => {
if (operator.operatorId === operator.operatorId) {
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
operatorTasks.push(operator);
pipeline.operatorSummaries.forEach(op => {
if (op.operatorId === operator.operatorId) {
operatorTasks.push(op);
}
});
}
Expand Down
10 changes: 5 additions & 5 deletions presto-ui/src/components/Splits.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ export default function Split(): void {
return {
taskId: task.taskId.substring(task.taskId.indexOf('.') + 1),
time: {
create: task.stats.createTime,
firstStart: task.stats.firstStartTime,
lastStart: task.stats.lastStartTime,
lastEnd: task.stats.lastEndTime,
end: task.stats.endTime,
create: task.stats.createTimeInMillis,
firstStart: task.stats.firstStartTimeInMillis,
lastStart: task.stats.lastStartTimeInMillis,
lastEnd: task.stats.lastEndTimeInMillis,
end: task.stats.endTimeInMillis,
},
};
});
Expand Down
6 changes: 3 additions & 3 deletions presto-ui/src/components/StageDetail.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,9 @@ function OperatorDetail({ index, operator, tasks }) {
tasksSorted.forEach(task => {
task.stats.pipelines.forEach(pipeline => {
if (pipeline.pipelineId === operator.pipelineId) {
pipeline.operatorSummaries.forEach(operator => {
if (operator.operatorId === operator.operatorId) {
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
operatorTasks.push(operator);
pipeline.operatorSummaries.forEach(op => {
if (op.operatorId === operator.operatorId) {
operatorTasks.push(op);
}
});
}
Expand Down
Loading