Skip to content

fix: Add session property back native_max_partial_aggregation_memory #26389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natashasehgal merged 1 commit into from
Oct 22, 2025
Merged

fix: Add session property back native_max_partial_aggregation_memory #26389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ava/com/facebook/presto/sessionpropertyproviders/NativeWorkerSessionPropertyProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,11 @@ public NativeWorkerSessionPropertyProvider(FeaturesConfig featuresConfig)
"preferred_output_batch_bytes and average row size estimates.",
10000,
!nativeExecution),
longProperty(
Copy link
Contributor

@sourcery-ai sourcery-ai bot Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (review_instructions): No accompanying documentation was added for the new session property NATIVE_MAX_PARTIAL_AGGREGATION_MEMORY.

Each session property added should have documentation, such as a comment or entry in a relevant doc file, explaining its purpose and usage. Please ensure documentation is provided for NATIVE_MAX_PARTIAL_AGGREGATION_MEMORY.

Review instructions:

Path patterns: **/NativeWorkerSessionPropertyProvider.java

Instructions:
Make sure that accompanying documentation is added for any session property which is added to this file.

NATIVE_MAX_PARTIAL_AGGREGATION_MEMORY,
"The max partial aggregation memory when data reduction is not optimal.",
1L << 24,
!nativeExecution),
longProperty(
NATIVE_MAX_EXTENDED_PARTIAL_AGGREGATION_MEMORY,
"The max partial aggregation memory when data reduction is optimal.",
Expand Down
Loading