Skip to content

feat(spi): Expose new QueryStatistic for totalScheduledTime #26279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaneja merged 1 commit into from
Oct 15, 2025
Merged

feat(spi): Expose new QueryStatistic for totalScheduledTime #26279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions presto-main-base/src/main/java/com/facebook/presto/event/QueryMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ public void queryImmediateFailureEvent(BasicQueryInfo queryInfo, ExecutionFailur
ofMillis(0),
ofMillis(0),
ofMillis(0),
ofMillis(0),
ofMillis(queryInfo.getQueryStats().getWaitingForPrerequisitesTime().toMillis()),
ofMillis(queryInfo.getQueryStats().getQueuedTime().toMillis()),
ofMillis(0),
Expand Down Expand Up @@ -430,6 +431,7 @@ private QueryStatistics createQueryStatistics(QueryInfo queryInfo)
return new QueryStatistics(
ofMillis(queryStats.getTotalCpuTime().toMillis()),
ofMillis(queryStats.getRetriedCpuTime().toMillis()),
ofMillis(queryStats.getElapsedTime().toMillis()),
Comment thread
aditi-pandit marked this conversation as resolved.
ofMillis(queryStats.getTotalScheduledTime().toMillis()),
ofMillis(queryStats.getWaitingForPrerequisitesTime().toMillis()),
ofMillis(queryStats.getQueuedTime().toMillis()),
Expand Down Expand Up @@ -470,6 +472,7 @@ private QueryStatistics createQueryStatistics(BasicQueryInfo basicQueryInfo)
return new QueryStatistics(
ofMillis(queryStats.getTotalCpuTime().toMillis()),
ofMillis(0),
ofMillis(queryStats.getElapsedTime().toMillis()),
ofMillis(queryStats.getTotalScheduledTime().toMillis()),
ofMillis(queryStats.getWaitingForPrerequisitesTime().toMillis()),
ofMillis(queryStats.getQueuedTime().toMillis()),
Expand Down
2 changes: 2 additions & 0 deletions presto-main/src/test/java/com/facebook/presto/eventlistener/TestEventListenerManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ public static QueryStatistics createDummyQueryStatistics()
Duration cpuTime = Duration.ofMillis(1000);
Duration retriedCpuTime = Duration.ofMillis(500);
Duration wallTime = Duration.ofMillis(2000);
Duration totalScheduledTime = Duration.ofMillis(2000);
Copy link
Copy Markdown
Contributor

@aaneja aaneja Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : Use a different value than wall time to make it obvious that this is the scheduled time metric ? Say Duration.ofMillis(2500)

Duration waitingForPrerequisitesTime = Duration.ofMillis(300);
Duration queuedTime = Duration.ofMillis(1500);
Duration waitingForResourcesTime = Duration.ofMillis(600);
Expand Down Expand Up @@ -257,6 +258,7 @@ public static QueryStatistics createDummyQueryStatistics()
cpuTime,
retriedCpuTime,
wallTime,
totalScheduledTime,
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (testing): No assertion verifying getTotalScheduledTime() behavior.

Please add assertions to check that getTotalScheduledTime() returns the expected value, and consider tests for its interaction with other statistics.

waitingForPrerequisitesTime,
queuedTime,
waitingForResourcesTime,
Expand Down
8 changes: 8 additions & 0 deletions presto-spi/src/main/java/com/facebook/presto/spi/eventlistener/QueryStatistics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public class QueryStatistics
private final Duration cpuTime;
private final Duration retriedCpuTime;
private final Duration wallTime;
private final Duration totalScheduledTime;
private final Duration waitingForPrerequisitesTime;
private final Duration queuedTime;
private final Duration waitingForResourcesTime;
Expand Down Expand Up @@ -64,6 +65,7 @@ public QueryStatistics(
Duration cpuTime,
Duration retriedCpuTime,
Duration wallTime,
Duration totalScheduledTime,
Duration waitingForPrerequisitesTime,
Duration queuedTime,
Duration waitingForResourcesTime,
Expand Down Expand Up @@ -98,6 +100,7 @@ public QueryStatistics(
this.cpuTime = requireNonNull(cpuTime, "cpuTime is null");
this.retriedCpuTime = requireNonNull(retriedCpuTime, "retriedCpuTime is null");
this.wallTime = requireNonNull(wallTime, "wallTime is null");
this.totalScheduledTime = requireNonNull(totalScheduledTime, "totalScheduledTime is null");
this.waitingForPrerequisitesTime = requireNonNull(waitingForPrerequisitesTime, "waitingForPrerequisitesTime is null");
this.queuedTime = requireNonNull(queuedTime, "queuedTime is null");
this.waitingForResourcesTime = requireNonNull(waitingForResourcesTime, "waitingForResourcesTime is null");
Expand Down Expand Up @@ -145,6 +148,11 @@ public Duration getWallTime()
return wallTime;
}

public Duration getTotalScheduledTime()
{
return totalScheduledTime;
}

public Duration getWaitingForPrerequisitesTime()
{
return waitingForPrerequisitesTime;
Expand Down
Loading