refactor(protocol): Add new generic thrift toolkit module for connectors #26259
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>com.facebook.presto</groupId> | ||
| <artifactId>presto-root</artifactId> | ||
| <version>0.297-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>presto-thrift-connector-toolkit</artifactId> | ||
| <name>presto-thrift-connector-toolkit</name> | ||
| <packaging>jar</packaging> | ||
|
|
||
| <properties> | ||
| <air.main.basedir>${project.parent.basedir}</air.main.basedir> | ||
| <air.check.skip-modernizer>true</air.check.skip-modernizer> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>com.facebook.airlift.drift</groupId> | ||
| <artifactId>drift-codec</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.facebook.airlift.drift</groupId> | ||
| <artifactId>drift-protocol</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.facebook.presto</groupId> | ||
| <artifactId>presto-spi</artifactId> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.facebook.airlift.drift</groupId> | ||
| <artifactId>drift-api</artifactId> | ||
| <version>${dep.drift.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
|
|
||
| <!-- Test dependencies --> | ||
| <dependency> | ||
| <groupId>org.testng</groupId> | ||
| <artifactId>testng</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.facebook.presto</groupId> | ||
| <artifactId>presto-testng-services</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.thrift.codec; | ||
|
|
||
| import com.facebook.drift.codec.ThriftCodecManager; | ||
| import com.facebook.presto.spi.ConnectorCodec; | ||
| import com.facebook.presto.spi.ConnectorDeleteTableHandle; | ||
| import com.facebook.presto.spi.ConnectorInsertTableHandle; | ||
| import com.facebook.presto.spi.ConnectorOutputTableHandle; | ||
| import com.facebook.presto.spi.ConnectorSplit; | ||
| import com.facebook.presto.spi.ConnectorTableHandle; | ||
| import com.facebook.presto.spi.ConnectorTableLayoutHandle; | ||
| import com.facebook.presto.spi.connector.ConnectorCodecProvider; | ||
| import com.facebook.presto.spi.connector.ConnectorTransactionHandle; | ||
|
|
||
| import java.lang.reflect.Type; | ||
| import java.util.Optional; | ||
|
|
||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class ThriftCodecProvider | ||
| implements ConnectorCodecProvider | ||
| { | ||
| private final ThriftCodecManager thriftCodecManager; | ||
| private final Optional<ConnectorCodec<ConnectorSplit>> connectorSplitCodec; | ||
| private final Optional<ConnectorCodec<ConnectorTransactionHandle>> connectorTransactionHandleCodec; | ||
| private final Optional<ConnectorCodec<ConnectorTableLayoutHandle>> connectorTableLayoutHandleCodec; | ||
| private final Optional<ConnectorCodec<ConnectorTableHandle>> connectorTableHandleCodec; | ||
| private final Optional<ConnectorCodec<ConnectorOutputTableHandle>> connectorOutputTableHandleCodec; | ||
| private final Optional<ConnectorCodec<ConnectorInsertTableHandle>> connectorInsertTableHandleCodec; | ||
| private final Optional<ConnectorCodec<ConnectorDeleteTableHandle>> connectorDeleteTableHandleCodec; | ||
|
|
||
| private ThriftCodecProvider(Builder builder) | ||
| { | ||
| this.thriftCodecManager = requireNonNull(builder.thriftCodecManager, "thriftCodecManager is null"); | ||
| this.connectorSplitCodec = builder.connectorSplitType.map(type -> new GenericThriftCodec<>(thriftCodecManager, type)); | ||
| this.connectorTransactionHandleCodec = builder.connectorTransactionHandle.map(type -> new GenericThriftCodec<>(thriftCodecManager, type)); | ||
| this.connectorTableLayoutHandleCodec = builder.connectorTableLayoutHandle.map(type -> new GenericThriftCodec<>(thriftCodecManager, type)); | ||
| this.connectorTableHandleCodec = builder.connectorTableHandle.map(type -> new GenericThriftCodec<>(thriftCodecManager, type)); | ||
| this.connectorOutputTableHandleCodec = builder.connectorOutputTableHandle.map(type -> new GenericThriftCodec<>(thriftCodecManager, type)); | ||
| this.connectorInsertTableHandleCodec = builder.connectorInsertTableHandle.map(type -> new GenericThriftCodec<>(thriftCodecManager, type)); | ||
| this.connectorDeleteTableHandleCodec = builder.connectorDeleteTableHandle.map(type -> new GenericThriftCodec<>(thriftCodecManager, type)); | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<ConnectorCodec<ConnectorSplit>> getConnectorSplitCodec() | ||
| { | ||
| return connectorSplitCodec; | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<ConnectorCodec<ConnectorTransactionHandle>> getConnectorTransactionHandleCodec() | ||
| { | ||
| return connectorTransactionHandleCodec; | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<ConnectorCodec<ConnectorTableLayoutHandle>> getConnectorTableLayoutHandleCodec() | ||
| { | ||
| return connectorTableLayoutHandleCodec; | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<ConnectorCodec<ConnectorTableHandle>> getConnectorTableHandleCodec() | ||
| { | ||
| return connectorTableHandleCodec; | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<ConnectorCodec<ConnectorOutputTableHandle>> getConnectorOutputTableHandleCodec() | ||
| { | ||
| return connectorOutputTableHandleCodec; | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<ConnectorCodec<ConnectorInsertTableHandle>> getConnectorInsertTableHandleCodec() | ||
| { | ||
| return connectorInsertTableHandleCodec; | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<ConnectorCodec<ConnectorDeleteTableHandle>> getConnectorDeleteTableHandleCodec() | ||
| { | ||
| return connectorDeleteTableHandleCodec; | ||
| } | ||
|
|
||
| public ThriftCodecManager getThriftCodecManager() | ||
| { | ||
| return thriftCodecManager; | ||
| } | ||
|
|
||
| public static class Builder | ||
| { | ||
| private ThriftCodecManager thriftCodecManager; | ||
| private Optional<Type> connectorSplitType = Optional.empty(); | ||
| private Optional<Type> connectorTransactionHandle = Optional.empty(); | ||
| private Optional<Type> connectorTableLayoutHandle = Optional.empty(); | ||
| private Optional<Type> connectorTableHandle = Optional.empty(); | ||
| private Optional<Type> connectorOutputTableHandle = Optional.empty(); | ||
| private Optional<Type> connectorInsertTableHandle = Optional.empty(); | ||
| private Optional<Type> connectorDeleteTableHandle = Optional.empty(); | ||
|
|
||
| public Builder setThriftCodecManager(ThriftCodecManager thriftCodecManager) | ||
| { | ||
| this.thriftCodecManager = thriftCodecManager; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder setConnectorSplitType(Class<? extends ConnectorSplit> type) | ||
| { | ||
| this.connectorSplitType = Optional.ofNullable(type); | ||
| return this; | ||
| } | ||
|
|
||
| public Builder setConnectorTransactionHandle(Class<? extends ConnectorTransactionHandle> type) | ||
| { | ||
| this.connectorTransactionHandle = Optional.ofNullable(type); | ||
| return this; | ||
| } | ||
|
|
||
| public Builder setConnectorTableLayoutHandle(Class<? extends ConnectorTableLayoutHandle> type) | ||
| { | ||
| this.connectorTableLayoutHandle = Optional.ofNullable(type); | ||
| return this; | ||
| } | ||
|
|
||
| public Builder setConnectorTableHandle(Class<? extends ConnectorTableHandle> type) | ||
| { | ||
| this.connectorTableHandle = Optional.ofNullable(type); | ||
| return this; | ||
| } | ||
|
|
||
| public Builder setConnectorOutputTableHandle(Class<? extends ConnectorOutputTableHandle> type) | ||
| { | ||
| this.connectorOutputTableHandle = Optional.ofNullable(type); | ||
| return this; | ||
| } | ||
|
|
||
| public Builder setConnectorInsertTableHandle(Class<? extends ConnectorInsertTableHandle> type) | ||
| { | ||
| this.connectorInsertTableHandle = Optional.ofNullable(type); | ||
| return this; | ||
| } | ||
|
|
||
| public Builder setConnectorDeleteTableHandle(Class<? extends ConnectorDeleteTableHandle> type) | ||
| { | ||
| this.connectorDeleteTableHandle = Optional.ofNullable(type); | ||
| return this; | ||
| } | ||
|
|
||
| public ThriftCodecProvider build() | ||
|
Contributor
There was a problem hiding this comment. Consider validating that |
||
| { | ||
| requireNonNull(thriftCodecManager, "ThriftCodecManager not set"); | ||
| return new ThriftCodecProvider(this); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we'll be sharing these among modules, could we add some basic unit tests that aren't tied to any particular module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tests