Skip to content

Advance Velox#26193

Open
tanjialiang wants to merge 1 commit intoprestodb:masterfrom
tanjialiang:adv_velox_0
Open

Advance Velox#26193
tanjialiang wants to merge 1 commit intoprestodb:masterfrom
tanjialiang:adv_velox_0

Conversation

@tanjialiang
Copy link
Contributor

Description

Advance Velox to the latest main

== NO RELEASE NOTE ==

@tanjialiang tanjialiang requested review from a team as code owners September 30, 2025 18:26
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Sep 30, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR advances the Velox dependency to the latest main branch by updating the submodule reference, aligning the CMake build configuration, and adapting the Presto integration code to upstream API changes.

File-Level Changes

Change Details Files
Bump Velox submodule to latest main commit
  • Updated the Git submodule reference to the newest Velox commit
  • Refreshed vendored Velox code to match upstream state
  • Removed obsolete local patches no longer needed
presto-native-execution/velox
Align CMake configuration with upstream changes
  • Updated CMakeLists targets and include directories
  • Added new dependency and compiler flags introduced upstream
  • Removed deprecated build options and variables
presto-native-execution/velox/CMakeLists.txt
Adapt Presto integration to Velox API updates
  • Adjusted function call signatures in the expression compiler
  • Replaced deprecated RowType usages with updated interfaces
  • Updated vector creation helpers to match new API
presto-native-execution/src/execution/VeloxNativeExpressionCompiler.cpp
presto-native-execution/src/execution/VeloxPlanConverter.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@czentgr
Copy link
Contributor

czentgr commented Oct 1, 2025

@tanjialiang there was a change in how connectors are registered.
@amitkdutta FYI. Should we work on this PR? We also want to move up Velox. You said someone from your side was working on the fix? If you need help we can help fixing it.

@tanjialiang
Copy link
Contributor Author

@tanjialiang there was a change in how connectors are registered. @amitkdutta FYI. Should we work on this PR? We also want to move up Velox. You said someone from your side was working on the fix? If you need help we can help fixing it.

Please feel free to move from your side.

@aditi-pandit
Copy link
Contributor

@czentgr : Feel free to pick this up if you have all the relevant background.

@czentgr
Copy link
Contributor

czentgr commented Oct 1, 2025

Replacement PR: #26209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants