Skip to content

Free more space for product-tests-specific-environment2#26161

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
unidevel:fix-test-action
Sep 26, 2025
Merged

Free more space for product-tests-specific-environment2#26161
tdcmeehan merged 1 commit intoprestodb:masterfrom
unidevel:fix-test-action

Conversation

@unidevel
Copy link
Contributor

Description

The action report no space:

Docker compose containers stopped: [singlenode-sqlserver]
Docker compose containers stopped: [singlenode]
Pulling docker image [mcr.microsoft.com/mssql/server:2022-latest]
failed to register layer: write /opt/mssql/lib/system.netfx.sfp: no space left on device
Error: Process completed with exit code 1.

Motivation and Context

Impact

CI

Test Plan

PR

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@unidevel unidevel requested review from a team and czentgr as code owners September 26, 2025 10:30
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Sep 26, 2025
@prestodb-ci prestodb-ci requested review from a team and ShahimSharafudeen and removed request for a team September 26, 2025 10:31
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 26, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR updates the product-tests-specific-environment workflow to replace ad-hoc shell commands with a maintained GitHub Action for freeing disk space, simplifying cleanup and improving reliability.

File-Level Changes

Change Details Files
Swap manual disk cleanup scripts for jlumbroso/free-disk-space action
  • Removed df, sudo apt-get clean and host cache removal steps
  • Added uses: jlumbroso/free-disk-space@v1.3.1
  • Configured action with docker-images: false
.github/workflows/product-tests-specific-environment.yml

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot previously requested changes Sep 26, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Blocking issues:

  • An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
  • An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/workflows/product-tests-specific-environment.yml:45` </location>
<code_context>
        uses: jlumbroso/free-disk-space@v1.3.1
</code_context>

<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

*Source: opengrep*
</issue_to_address>

### Comment 2
<location> `.github/workflows/product-tests-specific-environment.yml:109` </location>
<code_context>
        uses: jlumbroso/free-disk-space@v1.3.1
</code_context>

<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

*Source: opengrep*
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@unidevel
Copy link
Contributor Author

@sourcery-ai dismiss

@sourcery-ai sourcery-ai bot dismissed their stale review September 26, 2025 10:36

Automated Sourcery review dismissed.

Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @unidevel!

@tdcmeehan tdcmeehan merged commit ec07815 into prestodb:master Sep 26, 2025
76 of 78 checks passed
@imjalpreet imjalpreet linked an issue Sep 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky product test suite: singlenode-sqlserver

3 participants