Skip to content

Fix local presto server start on latest master#26144

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
agrawalreetika:local-build-fix
Sep 25, 2025
Merged

Fix local presto server start on latest master#26144
tdcmeehan merged 1 commit intoprestodb:masterfrom
agrawalreetika:local-build-fix

Conversation

@agrawalreetika
Copy link
Member

Description

Fix the local Presto server to start on the latest master

Motivation and Context

After rebasing to the latest master, I was getting the following error while starting the server on the IDE with default configs -

image

Impact

Presto server start fails on local IDE

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@agrawalreetika agrawalreetika self-assigned this Sep 24, 2025
@agrawalreetika agrawalreetika requested a review from a team as a code owner September 24, 2025 16:53
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Sep 24, 2025
@prestodb-ci prestodb-ci requested review from a team, libianoss and xin-zhang2 and removed request for a team September 24, 2025 16:53
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR corrects the plugin bundle path in config.properties to match the new module location, restoring the ability to start a local Presto server on the latest master.

File-Level Changes

Change Details Files
Corrected plugin bundle path for SQL-invoked functions plugin
  • Updated relative path to the SQL-invoked-functions plugin under presto-sql-helpers
presto-main/etc/config.properties

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@imjalpreet imjalpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @agrawalreetika

Copy link
Contributor

@pdabre12 pdabre12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrawalreetika Thanks for this fix

@tdcmeehan tdcmeehan merged commit d50763e into prestodb:master Sep 25, 2025
75 checks passed
@agrawalreetika agrawalreetika deleted the local-build-fix branch September 26, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants