Skip to content

Use NodeAssignmentStats::getQueuedSplitsWeightForStage in task-based split scheduling #26124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spershin merged 1 commit into from
Sep 23, 2025
Merged

Use NodeAssignmentStats::getQueuedSplitsWeightForStage in task-based split scheduling #26124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...c/main/java/com/facebook/presto/execution/scheduler/nodeSelection/SimpleNodeSelector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,13 +256,11 @@ private ToLongFunction<InternalNode> createTaskLoadSplitWeightProvider(List<Remo
RemoteTask remoteTask = tasksByNodeId.get(node.getNodeIdentifier());
if (remoteTask == null) {
// No task for this node, return only the queued splits weight for the stage
return assignmentStats.getAssignedSplitsWeightForStage(node);
return assignmentStats.getQueuedSplitsWeightForStage(node);
}

TaskStatus taskStatus = remoteTask.getTaskStatus();
return taskStatus.getQueuedPartitionedSplitsWeight() +
taskStatus.getRunningPartitionedSplitsWeight() +
assignmentStats.getAssignedSplitsWeightForStage(node);
return taskStatus.getRunningPartitionedSplitsWeight() + assignmentStats.getQueuedSplitsWeightForStage(node);
};
}

Expand Down
1 change: 0 additions & 1 deletion presto-main-base/src/test/java/com/facebook/presto/execution/TestNodeScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,6 @@ public void testScheduleSplitsBasedOnTaskLoad()
assertTrue(node.getNodeIdentifier().equals("other2") || node.getNodeIdentifier().equals("other3"));
}

Map<RemoteTask, Multimap<PlanNodeId, Split>> splitsForTasks = new HashMap<>();
PlanNodeId planNodeId = new PlanNodeId("sourceId");
for (InternalNode node : assignments.keySet()) {
Multimap<PlanNodeId, Split> splits = ArrayListMultimap.create();
Expand Down
Loading