Fix Flaky Test in Clickhouse CI

[nishithakbhaskaran]

Description

Fix flaky test in Clickhouse CI

Motivation and Context

Resolves #26079

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjust the ClickHouse test setup to bind to an ephemeral HTTP port instead of a fixed port to prevent CI test flakes due to port conflicts.

File-Level Changes

Change	Details	Files
Use ephemeral HTTP port in TestingClickHouseServer	Changed hard-coded port "8080" to "0" in server configuration map	presto-clickhouse/src/test/java/com/facebook/presto/plugin/clickhouse/TestClickHouseDistributedQueries.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Add a brief comment explaining that port "0" is used to request an ephemeral port and avoid conflicts in CI.
• Verify that the ClickHouse query runner properly reads and propagates the dynamically assigned port rather than assuming a fixed value.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Add a brief comment explaining that port "0" is used to request an ephemeral port and avoid conflicts in CI.
- Verify that the ClickHouse query runner properly reads and propagates the dynamically assigned port rather than assuming a fixed value.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[imjalpreet]

Thank you, @nishithakbhaskaran. I just faced the issue and saw you already fixed it.

[imjalpreet]

I think this is handled in TestingPrestoServer as well. If we just don't add this property, it will default to 0. Can we try that too?

presto/presto-main/src/main/java/com/facebook/presto/server/testing/TestingPrestoServer.java

Lines 303 to 306 in b0f44f0

	String coordinatorPort = properties.remove("http-server.http.port");
	if (coordinatorPort == null) {
	coordinatorPort = "0";
	}

[nishithakbhaskaran]

Sure, let me try out.

[tdcmeehan]

Thank you @nishithakbhaskaran

[imjalpreet]

Thanks, @nishithakbhaskaran. Just a small suggestion.

[imjalpreet]

It looks like it will work. We can refactor to use the other constructor

https://github.com/prestodb/presto/blob/master/presto-clickhouse/src/test/java/com/facebook/presto/plugin/clickhouse/ClickHouseQueryRunner.java#L39C5-L43C6

[nishithakbhaskaran]

Updated.PTAL