[Doc] Correct session property details in release notes#26046
[Doc] Correct session property details in release notes#26046tdcmeehan merged 2 commits intoprestodb:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdated the 0.292 release notes to correct the referenced session property name, default value, and description in the documentation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local doc build, looks good.
Thanks for catching this!
0195dab to
de0a2ca
Compare
de0a2ca to
a18fd9d
Compare
|
@steveburnett I did rebase this PR on latest master but above tests seem to be failing on Doc PR with below error - Wanted to check if this is something known? And I suppose this is not happening in other PRs |
0ba640f
Hi @agrawalreetika! I don't know why these tests are failing. I haven't noticed this happening in other PRs. @unidevel, can you help identify the problem here? |
|
I have no issue to rebase the branch HEAD is now at 0ba640fa89 temp
[I] ~/m/presto (releasenotes)> git fetch origin
remote: Enumerating objects: 197, done.
remote: Counting objects: 100% (155/155), done.
remote: Compressing objects: 100% (63/63), done.
remote: Total 197 (delta 54), reused 119 (delta 46), pack-reused 42 (from 3)
Receiving objects: 100% (197/197), 107.62 KiB | 1.43 MiB/s, done.
Resolving deltas: 100% (54/54), completed with 37 local objects.
From github.com:prestodb/presto
41016fee70..859f0206e5 master -> origin/master
* [new branch] now-function-and-jmx-fix -> origin/now-function-and-jmx-fix
123c9043c8..ad0250e88b release-0.295-edge12 -> origin/release-0.295-edge12
42c5c1a3e8..92af90ee31 release-0.295-edge13 -> origin/release-0.295-edge13
0788f73f6c..002144d64d release-0.295-edge14 -> origin/release-0.295-edge14
* [new branch] release-0.295-edge15 -> origin/release-0.295-edge15
* [new branch] release-0.295-edge16 -> origin/release-0.295-edge16
Fetching submodule presto-native-execution/velox
From https://github.com/facebookincubator/velox
* branch 132db14c2deae135f7392575441c09c98f283327 -> FETCH_HEAD
[I] ~/m/presto (releasenotes)> git rebase origin/master
Successfully rebased and updated refs/heads/releasenotes.
|
|
I noticed the same test seems to be failing on #26030. Maybe that will help identify the problem. |
0ba640f to
1c1b31a
Compare
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build. Looks good. Thanks again for this!
Description
Correct session property details in release notes
Looks like release notes in PR mentioned different session property name - #24047 (comment)
Motivation and Context
Correct release notes information
Impact
Correct release notes information
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.