Skip to content

[Doc] Correct session property details in release notes#26046

Merged
tdcmeehan merged 2 commits intoprestodb:masterfrom
agrawalreetika:releasenotes
Sep 18, 2025
Merged

[Doc] Correct session property details in release notes#26046
tdcmeehan merged 2 commits intoprestodb:masterfrom
agrawalreetika:releasenotes

Conversation

@agrawalreetika
Copy link
Member

Description

Correct session property details in release notes
Looks like release notes in PR mentioned different session property name - #24047 (comment)

Motivation and Context

Correct release notes information

Impact

Correct release notes information

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Sep 16, 2025
@prestodb-ci prestodb-ci requested review from a team, Joe-Abraham and namya28 and removed request for a team September 16, 2025 05:47
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updated the 0.292 release notes to correct the referenced session property name, default value, and description in the documentation.

File-Level Changes

Change Details Files
Corrected session property details in the release notes
  • Renamed the incorrect session property to the proper name
  • Adjusted the documented default value
  • Reworded the description to match actual behavior
presto-docs/src/main/sphinx/release/release-0.292.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@agrawalreetika agrawalreetika changed the title Correct session property details in release notes [Doc] Correct session property details in release notes Sep 16, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

steveburnett
steveburnett previously approved these changes Sep 16, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good.

Thanks for catching this!

@github-project-automation github-project-automation bot moved this from 🆕 Unprioritized to ✅ Done in Presto Documentation Sep 16, 2025
tdcmeehan
tdcmeehan previously approved these changes Sep 17, 2025
@agrawalreetika
Copy link
Member Author

agrawalreetika commented Sep 17, 2025

@steveburnett I did rebase this PR on latest master but above tests seem to be failing on Doc PR with below error -

Error: Unable to download artifact(s): Artifact not found for name: presto-native-build
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

Wanted to check if this is something known? And I suppose this is not happening in other PRs

@steveburnett
Copy link
Contributor

@steveburnett I did rebase this PR on latest master but above tests seem to be failing on Doc PR with below error -

Error: Unable to download artifact(s): Artifact not found for name: presto-native-build
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

Wanted to check if this is something known? And I suppose this is not happening in other PRs

Hi @agrawalreetika! I don't know why these tests are failing. I haven't noticed this happening in other PRs.

@unidevel, can you help identify the problem here?

@unidevel
Copy link
Contributor

I have no issue to rebase the branch

HEAD is now at 0ba640fa89 temp
[I] ~/m/presto (releasenotes)> git fetch origin
remote: Enumerating objects: 197, done.
remote: Counting objects: 100% (155/155), done.
remote: Compressing objects: 100% (63/63), done.
remote: Total 197 (delta 54), reused 119 (delta 46), pack-reused 42 (from 3)
Receiving objects: 100% (197/197), 107.62 KiB | 1.43 MiB/s, done.
Resolving deltas: 100% (54/54), completed with 37 local objects.
From github.com:prestodb/presto
   41016fee70..859f0206e5  master                   -> origin/master
 * [new branch]            now-function-and-jmx-fix -> origin/now-function-and-jmx-fix
   123c9043c8..ad0250e88b  release-0.295-edge12     -> origin/release-0.295-edge12
   42c5c1a3e8..92af90ee31  release-0.295-edge13     -> origin/release-0.295-edge13
   0788f73f6c..002144d64d  release-0.295-edge14     -> origin/release-0.295-edge14
 * [new branch]            release-0.295-edge15     -> origin/release-0.295-edge15
 * [new branch]            release-0.295-edge16     -> origin/release-0.295-edge16
Fetching submodule presto-native-execution/velox
From https://github.com/facebookincubator/velox
 * branch                132db14c2deae135f7392575441c09c98f283327 -> FETCH_HEAD
[I]  ~/m/presto (releasenotes)> git rebase origin/master
Successfully rebased and updated refs/heads/releasenotes.

@steveburnett
Copy link
Contributor

I noticed the same test seems to be failing on #26030. Maybe that will help identify the problem.

@agrawalreetika
Copy link
Member Author

agrawalreetika commented Sep 18, 2025

@unidevel, thanks for checking.

But I think when you tried rebase on this branch, I added a fix commit for excludingprestocpp-linux-presto-on-spark-e2e-tests from presto-docs PR that was causing failure earlier on docs PR, which was introduced as part of a37b445

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build. Looks good. Thanks again for this!

@tdcmeehan tdcmeehan merged commit e840f09 into prestodb:master Sep 18, 2025
92 of 94 checks passed
@agrawalreetika agrawalreetika deleted the releasenotes branch September 18, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants