Fix version-specific Spark profiles#25940
Merged
ghelmling merged 1 commit intoprestodb:masterfrom Sep 4, 2025
Merged
Conversation
1967be1 to
662e68e
Compare
662e68e to
f11e65a
Compare
f11e65a to
478bf84
Compare
rschlussel
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reworks the presto-spark-classloader-spark2 and presto-spark-classloader-spark3 modules used for binding to version-specific Spark releases. This changes the way the modules are handled during the build by controlling their inclusion via Maven profiles:
Motivation and Context
A prior version of the spark3 profile was added in PR #25552. However, this controlled the module included by manipulating the module name, appending a version number at the end. Not having the full module name listed confused other plugins which analyze the project POM, like the versions plugin. As a result, running
mvn versions:setwas not able to update the version for the presto-spark-classloader-spark2 and presto-spark-classloader-spark3 modules. With this changemvn versions:setis able to update both module versions.Impact
Test Plan
Built with both the spark2 and spark3 modules and verified that the correct presto-spark-classloader-sparkN dependency is included.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.