Skip to content

fix: Deserialized TDigest NaN checks #25907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
+23 −0
Merged

fix: Deserialized TDigest NaN checks #25907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b7e229
fix: Deserialized TDigest NaN checks (#25907)
natashasehgal Aug 28, 2025
97347e6
Merge branch 'prestodb:master' into export-D81173686
natashasehgal Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions presto-main-base/src/main/java/com/facebook/presto/tdigest/TDigest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,13 @@ public static TDigest createTDigest(Slice slice)
r.mean = new double[r.activeCentroids];
sliceInput.readBytes(wrappedDoubleArray(r.weight), r.activeCentroids * SIZE_OF_DOUBLE);
sliceInput.readBytes(wrappedDoubleArray(r.mean), r.activeCentroids * SIZE_OF_DOUBLE);

// Validate deserialized TDigest data
for (int i = 0; i < r.activeCentroids; i++) {
checkArgument(!isNaN(r.mean[i]), "Deserialized t-digest contains NaN mean value");
checkArgument(r.weight[i] > 0, "weight must be > 0");
}

sliceInput.close();
return r;
}
Expand Down Expand Up @@ -712,6 +719,12 @@ public long estimatedInMemorySizeInBytes()

public Slice serialize()
{
// Validate data before serialization
for (int i = 0; i < activeCentroids; i++) {
checkArgument(!isNaN(mean[i]), "Cannot serialize t-digest with NaN mean value");
checkArgument(weight[i] > 0, "Cannot serialize t-digest with non-positive weight");
}

SliceOutput sliceOutput = new DynamicSliceOutput(toIntExact(estimatedSerializedSizeInBytes()));

sliceOutput.writeByte(1); // version 1 of T-Digest serialization
Expand Down
10 changes: 10 additions & 0 deletions presto-main-base/src/test/java/com/facebook/presto/tdigest/TestTDigest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,16 @@ public void testGeometricDistribution()
}
}

@Test(expectedExceptions = IllegalArgumentException.class, expectedExceptionsMessageRegExp = ".*Cannot serialize t-digest with NaN mean value.*")
public void testSerializationWithNaNMean()
{
double[] means = {1.0, Double.NaN, 3.0};
double[] weights = {1.0, 1.0, 1.0};
TDigest tDigest = createTDigest(means, weights, STANDARD_COMPRESSION_FACTOR, 1.0, 3.0, 6.0, 3);

tDigest.serialize();
}

@Test(enabled = false)
public void testPoissonDistribution()
{
Expand Down
Loading