Consider using the opinionated-commit-message Github Action #23967#25897
Consider using the opinionated-commit-message Github Action #23967#25897rebeccaSimmonds19 wants to merge 1 commit intoprestodb:masterfrom
Conversation
…23967 Fix prestodb#23967 Added file check-commit-message.yml to the workflows folder to allow for auto check of commits
|
@rebeccaSimmonds19 would it be possible to cross check this plugin against several recent PRs to understand if it's doing the right thing? |
|
Did we have a discussion on this? For PrestoC++ changes we add @tdcmeehan I would propose scheme similar to Velox for commit messages (specifically the abstract) which itself was inspired by Arrow. Such scheme would counter this particular check here. Perhaps we should discuss this or was it discussed? |
|
@czentgr yes, I previously brought this up here: https://github.com/orgs/prestodb/discussions/23834 I'm wondering if there is an equivalent plugin for convention commits |
Sorry for the late reply. Would you know a way to run github actions against a a PR on the repository at all? |
|
@rebeccaSimmonds19 it might be best to hold off for now, as I think we need to get community consensus on what approach to take--conventional commits, or the opinionated commit message style. We have a TSC meeting tomorrow where I'll bring this up, I'll update here with the outcome. |
|
Does #26122 affect this PR? |
|
Yes, we are now moving to conventional commits. Thank you for the work on adding this @rebeccaSimmonds19 |
Fix #23967
Added file check-commit-message.yml to the workflows folder to allow for auto check of commits
Description
This has added a automated check for commit messages using this. This is done by adding a check-commit-message.yml file to the workflows directory
Motivation and Context
This will help reduce work on reviewers and help new contributors
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.