Skip to content

Conversation

@aaneja
Copy link
Contributor

@aaneja aaneja commented Aug 18, 2025

Original support was added via #2ad67dcf,
but missed adding it for Iceberg tables

Cherry-pick of trinodb/trino#4144

Impact

Inserting into Iceberg tables will honor NOT NULL constraints on columns

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Aug 18, 2025
Original support was added via #2ad67dcf,
but missed adding it for Iceberg tables

Cherry-pick of trinodb/trino#4144
Co-authored-by: djsstarburst <[email protected]>
@aaneja aaneja force-pushed the icebergNotNullEnforce branch from 9856603 to b3ed8a2 Compare August 19, 2025 04:23
@aaneja aaneja marked this pull request as ready for review August 19, 2025 04:23
@aaneja aaneja requested review from a team, ZacBlanco and hantangwangd as code owners August 19, 2025 04:23
@prestodb-ci prestodb-ci requested review from a team, jkhaliqi and libianoss and removed request for a team August 19, 2025 04:23
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@aaneja aaneja merged commit 2b59d23 into prestodb:master Aug 20, 2025
100 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants