Skip to content

Add kQueryTraceNodeId in presto session config #25684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Add kQueryTraceNodeId in presto session config #25684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions presto-docs/src/main/sphinx/presto_cpp/properties-session.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ underlying file system.
* **Default value:** ``false``

Enable query tracing. After enabled, trace data will be generated with query execution, and
can be used by TraceReplayer. It needs to be used together with native_query_trace_node_ids,
can be used by TraceReplayer. It needs to be used together with native_query_trace_node_id,
native_query_trace_max_bytes, native_query_trace_fragment_id, and native_query_trace_shard_id
to match the task to be traced.

Expand All @@ -358,14 +358,13 @@ to match the task to be traced.

The location to store the trace files.

``native_query_trace_node_ids``
``native_query_trace_node_id``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

* **Type:** ``varchar``
* **Default value:** ``""``

A comma-separated list of plan node ids whose input data will be traced.
Empty string if only want to trace the query metadata.
The plan node id whose input data will be traced.

``native_query_trace_max_bytes``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down Expand Up @@ -487,4 +486,4 @@ This is used in global arbitration victim selection.
* **Default value:** ``0``

Maximum number of splits to listen to by the SplitListener per table scan node per
native worker.
native worker.
6 changes: 3 additions & 3 deletions ...ava/com/facebook/presto/sessionpropertyproviders/NativeWorkerSessionPropertyProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public class NativeWorkerSessionPropertyProvider
public static final String NATIVE_MAX_OUTPUT_BUFFER_SIZE = "native_max_output_buffer_size";
public static final String NATIVE_QUERY_TRACE_ENABLED = "native_query_trace_enabled";
public static final String NATIVE_QUERY_TRACE_DIR = "native_query_trace_dir";
public static final String NATIVE_QUERY_TRACE_NODE_IDS = "native_query_trace_node_ids";
public static final String NATIVE_QUERY_TRACE_NODE_ID = "native_query_trace_node_id";
public static final String NATIVE_QUERY_TRACE_MAX_BYTES = "native_query_trace_max_bytes";
public static final String NATIVE_QUERY_TRACE_FRAGMENT_ID = "native_query_trace_fragment_id";
public static final String NATIVE_QUERY_TRACE_SHARD_ID = "native_query_trace_shard_id";
Expand Down Expand Up @@ -243,8 +243,8 @@ public NativeWorkerSessionPropertyProvider(FeaturesConfig featuresConfig)
"Base dir of a query to store tracing data.",
"",
!nativeExecution),
stringProperty(NATIVE_QUERY_TRACE_NODE_IDS,
"A comma-separated list of plan node ids whose input data will be traced. Empty string if only want to trace the query metadata.",
stringProperty(NATIVE_QUERY_TRACE_NODE_ID,
"The plan node id whose input data will be traced.",
"",
!nativeExecution),
longProperty(NATIVE_QUERY_TRACE_MAX_BYTES,
Expand Down
9 changes: 4 additions & 5 deletions presto-native-execution/presto_cpp/main/SessionProperties.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,13 +301,12 @@ SessionProperties::SessionProperties() {
c.queryTraceDir());

addSessionProperty(
kQueryTraceNodeIds,
"A comma-separated list of plan node ids whose input data will be traced."
" Empty string if only want to trace the query metadata.",
kQueryTraceNodeId,
"The plan node id whose input data will be traced.",
VARCHAR(),
false,
QueryConfig::kQueryTraceNodeIds,
c.queryTraceNodeIds());
QueryConfig::kQueryTraceNodeId,
c.queryTraceNodeId());

addSessionProperty(
kQueryTraceMaxBytes,
Expand Down
9 changes: 4 additions & 5 deletions presto-native-execution/presto_cpp/main/SessionProperties.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,9 @@ class SessionProperties {
/// Base dir of a query to store tracing data.
static constexpr const char* kQueryTraceDir = "native_query_trace_dir";

/// A comma-separated list of plan node ids whose input data will be traced.
/// Empty string if only want to trace the query metadata.
static constexpr const char* kQueryTraceNodeIds =
"native_query_trace_node_ids";
/// The plan node id whose input data will be traced.
static constexpr const char* kQueryTraceNodeId =
"native_query_trace_node_id";

/// The max trace bytes limit. Tracing is disabled if zero.
static constexpr const char* kQueryTraceMaxBytes =
Expand Down Expand Up @@ -310,7 +309,7 @@ class SessionProperties {
"native_streaming_aggregation_min_output_batch_rows";

/// Maximum wait time for exchange long poll requests in seconds.
static constexpr const char* kRequestDataSizesMaxWaitSec =
static constexpr const char* kRequestDataSizesMaxWaitSec =
"native_request_data_sizes_max_wait_sec";

/// Priority of memory pool reclaimer when deciding on memory pool to abort.
Expand Down
Loading