Skip to content

Conversation

@steveburnett
Copy link
Contributor

@steveburnett steveburnett commented Jun 30, 2025

Description

Add doc for offset-clause-enabled and offset_clause_enabled configuration and session properties. Fixes #25453.

Motivation and Context

In a comment on #25216, @xieandrew mentioned
Separately, it may be important to document the offset_clause_enabled session prop and offset-clause-enabled configuration prop since those are needed by the user to actually use the main feature this fix relates to. I only see those properties in a release note: https://prestodb.io/docs/current/release/release-0.257.html#general-changes.

Impact

Documentation.

Test Plan

Local doc builds. Screenshots:

Configuration property offset-clause-enabled
Screenshot 2025-06-30 at 3 12 34 PM

Session property offset_clause_enabled
Screenshot 2025-06-30 at 3 12 39 PM

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@steveburnett steveburnett self-assigned this Jun 30, 2025
@steveburnett steveburnett requested review from a team and elharo as code owners June 30, 2025 19:29
@github-project-automation github-project-automation bot moved this to 🆕 Unprioritized in Presto Documentation Jun 30, 2025
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jun 30, 2025
@prestodb-ci prestodb-ci requested review from a team, Dilli-Babu-Godari and ShahimSharafudeen and removed request for a team June 30, 2025 19:29
@steveburnett steveburnett moved this from 🆕 Unprioritized to 👀 Review in Presto Documentation Jun 30, 2025
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steveburnett Thanks for adding this, lgtm!

@github-project-automation github-project-automation bot moved this from 👀 Review to ✅ Done in Presto Documentation Jul 2, 2025
@steveburnett steveburnett merged commit 1b2a402 into prestodb:master Jul 2, 2025
106 checks passed
@steveburnett steveburnett deleted the steveburnett-offset-properties branch July 2, 2025 13:58
@prestodb-ci prestodb-ci mentioned this pull request Jul 28, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs from:IBM PR from IBM

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[docs] Add doc for offset_clause_enabled session and offset-clause-enabled configuration properties

3 participants