Add max column config and session properties to equality delete as jo…#25462
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Jul 2, 2025
Merged
Add max column config and session properties to equality delete as jo…#25462tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
f35ec66 to
4c66ee5
Compare
steveburnett
requested changes
Jun 30, 2025
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
Formatting suggestions. The text itself reads fine, no concern with the content.
4c66ee5 to
5c82920
Compare
Contributor
Author
|
Thanks @steveburnett, I've incorporated your suggestions! |
hantangwangd
reviewed
Jul 1, 2025
Member
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks for this change, lgtm overall. Just some little nits.
presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergConfig.java
Outdated
Show resolved
Hide resolved
steveburnett
previously approved these changes
Jul 1, 2025
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build. Looks good, thanks!
hantangwangd
approved these changes
Jul 2, 2025
Member
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks for the fix, lgtm!
This was referenced Jul 4, 2025
7 tasks
9 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in optimizer
Description
Adds session and config properties to the Iceberg connector allowing users to toggle the Iceberg delete-as-optimize rule based on the column count of the delete file. Deprecates the old binary flag, in the future it will be deleted and replaced with the column count toggle.
Motivation and Context
Fixes #25455 by introducing an upper bound to the number of columns allowed to use this optimization.
Impact
Fix #25455
Test Plan
Added unit tests demonstrating the toggling of the optimization.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.