build: Add Presto native C++ dev container by mblanco-denodo · Pull Request #25358 · prestodb/presto

mblanco-denodo · 2025-06-18T14:18:16Z

Description

Added dev container for Presto native C++

Motivation and Context

Ease Presto native C++ development

Impact

Test Plan

Contributor checklist

Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

steveburnett · 2025-07-03T17:01:35Z

@mblanco-denodo, there have been some fixes to the CI tests since the last activity on this PR. If you rebase, these pending tests might pass.

mblanco-denodo · 2025-10-10T09:52:33Z

Hi! I've rebased and updated the devcontainer generation to be mounted from CLion, so that it uses the prestissimo dependency image leveraging us from the need to maintain the devcontainer. This should work if the dependency images work. I've also added documentation on how to configure it

steveburnett

Thanks for the documentation! I made some suggestions and had questions. Let me know what you think, and ask if anything I wrote is unclear.

presto-native-execution/README.md

presto-native-execution/.devcontainer/README.md

steveburnett

Thanks for the doc fixes! One minor suggestion.

presto-native-execution/.devcontainer/README.md

czentgr

FYI, we also have another devcontainer setup: https://github.com/prestodb/presto-dev
But this is more about integration with CLion.

czentgr · 2025-10-10T19:59:35Z

presto-native-execution/.devcontainer/install-shared-libs.sh

+# Copy shared libs to the directory /runtime-libraries
+mkdir /runtime-libraries && \
+    bash -c '!(LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:/usr/local/lib:/usr/local/lib64 ldd ../cmake-build-debug/presto_cpp/main/presto_server | grep "not found")' && \
+    LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:/usr/local/lib:/usr/local/lib64 ldd ../cmake-build-debug/presto_cpp/main/presto_server | awk 'NF == 4 { system("cp " $3 " /runtime-libraries") }'


Need new line at the end.

czentgr · 2025-10-10T19:59:50Z

presto-native-execution/.devcontainer/install-shared-libs.sh

@@ -0,0 +1,6 @@
+#!/bin/bash
+# Before executing this script, you should compile presto_server


What happens if you don't. Will CLion throw an error?

No, this is only to match the release environment, making sure that you're executing the server this the same libraries as the release version. This way, if your compilation lacks any library, you should see failures during the execution before the code is integrated into master

steveburnett

LGTM! (docs)

presto-native-execution/.devcontainer/Dockerfile

unidevel

Thanks, looks good!

steveburnett · 2025-12-09T16:38:24Z

Re-ran the two required and failing tests for this PR in case the failure had been a glitch of some kind.

https://github.com/prestodb/presto/actions/runs/19330815080/job/57571744640?pr=25358
failed again with
failed to register layer: write /usr/hdp/3.1.0.0-78/hadoop/mapreduce.tar.gz: no space left on device.

mblanco-denodo · 2025-12-10T19:56:24Z

HI! I've rebased my changes with master

tdcmeehan

Feel free to self merge once CI is green. Thanks for the doc and this feature.

mblanco-denodo · 2025-12-19T12:16:01Z

@tdcmeehan tests are a bit unstable. The feature will not affect anything as it does not change any presto code. Can you merge please?

Feel free to self merge once CI is green. Thanks for the doc and this feature.

## Description Added dev container for Presto native C++ ## Motivation and Context   Ease Presto native C++ development ## Impact  ## Test Plan  ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```

mblanco-denodo requested a review from a team as a code owner June 18, 2025 14:18

mblanco-denodo mentioned this pull request Sep 9, 2025

Add Presto Java dev container #25344

Merged

6 tasks

mblanco-denodo force-pushed the dev_container_c++ branch from a1d3f8d to 235dd55 Compare October 10, 2025 09:50

mblanco-denodo requested review from a team and steveburnett as code owners October 10, 2025 09:50

mblanco-denodo changed the title ~~Add Presto native C++ dev container~~ build: Add Presto native C++ dev container Oct 10, 2025

steveburnett requested changes Oct 10, 2025

View reviewed changes

majetideepak requested review from czentgr and majetideepak October 16, 2025 15:32

mblanco-denodo force-pushed the dev_container_c++ branch from d1540a6 to 49afaab Compare October 27, 2025 12:43

mblanco-denodo requested a review from steveburnett October 27, 2025 12:43

mblanco-denodo force-pushed the dev_container_c++ branch from 49afaab to d312725 Compare October 27, 2025 13:32

steveburnett requested changes Oct 27, 2025

View reviewed changes

presto-native-execution/.devcontainer/README.md Outdated Show resolved Hide resolved

mblanco-denodo force-pushed the dev_container_c++ branch 2 times, most recently from f9a403f to 68c61fd Compare October 27, 2025 14:31

czentgr reviewed Oct 27, 2025

View reviewed changes

steveburnett previously approved these changes Oct 27, 2025

View reviewed changes

mblanco-denodo requested a review from czentgr October 27, 2025 15:25

tdcmeehan requested a review from unidevel November 10, 2025 17:40

unidevel reviewed Nov 10, 2025

View reviewed changes

presto-native-execution/.devcontainer/Dockerfile Show resolved Hide resolved

unidevel reviewed Nov 10, 2025

View reviewed changes

presto-native-execution/.devcontainer/Dockerfile Show resolved Hide resolved

mblanco-denodo dismissed steveburnett’s stale review via 48f2b73 November 13, 2025 12:00

mblanco-denodo force-pushed the dev_container_c++ branch from 68c61fd to 48f2b73 Compare November 13, 2025 12:00

mblanco-denodo requested a review from unidevel November 13, 2025 12:01

unidevel reviewed Nov 14, 2025

View reviewed changes

presto-native-execution/.devcontainer/Dockerfile Show resolved Hide resolved

unidevel approved these changes Nov 19, 2025

View reviewed changes

mblanco-denodo force-pushed the dev_container_c++ branch from 48f2b73 to 02293d2 Compare December 10, 2025 19:55

tdcmeehan approved these changes Dec 10, 2025

View reviewed changes

mblanco-denodo force-pushed the dev_container_c++ branch 2 times, most recently from 36de667 to 3eeabe5 Compare December 19, 2025 09:44

mblanco-denodo added 6 commits January 8, 2026 14:53

Added presto native c++ dev container

579118e

Use PROMPT_ALWAYS_RESPOND=n after package installation

67fa937

Added Presto c++ devcontainer

6e481b8

Add link to the devcontainer deploy guide from the presto c++ readme

737549c

Fix documentation after review

0485127

Added java-17 jdk and precommit checks

10baf4c

mblanco-denodo force-pushed the dev_container_c++ branch from 3eeabe5 to 10baf4c Compare January 8, 2026 13:53

tdcmeehan merged commit 7e44169 into prestodb:master Jan 8, 2026
80 of 81 checks passed

This was referenced Mar 31, 2026

docs: Add release notes for 0.297 unix280/presto#51

Closed

docs: Add release notes for 0.297 unix280/presto#52

Open

		@@ -0,0 +1,6 @@
		#!/bin/bash
		# Before executing this script, you should compile presto_server

Conversation

mblanco-denodo commented Jun 18, 2025

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

Uh oh!

steveburnett commented Jul 3, 2025

Uh oh!

mblanco-denodo commented Oct 10, 2025

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

czentgr left a comment

Choose a reason for hiding this comment

Uh oh!

czentgr Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

czentgr Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

mblanco-denodo Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

unidevel left a comment

Choose a reason for hiding this comment

Uh oh!

steveburnett commented Dec 9, 2025

Uh oh!

mblanco-denodo commented Dec 10, 2025

Uh oh!

tdcmeehan left a comment

Choose a reason for hiding this comment

Uh oh!

mblanco-denodo commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mblanco-denodo commented Dec 19, 2025 •

edited

Loading