Add aws-java-sdk-core as runtime dependency for Redshift JDBC driver

[adkharat]

Description

Git Issue: #25247

Amazon Redshift JDBC driver version 2.1.0.32 internally depends on com.amazonaws.util.StringUtils class from the AWS SDK v1.

This com.amazonaws.util.StringUtils class is not bundled inside the Redshift JDBC driver jar, and it must be available on the classpath.

Added aws-java-sdk-core as a runtime dependency to resolve this issue.

Motivation and Context

The Presto Redshift connector fails with a NoClassDefFoundError during table operations like CREATE TABLE because it tries to invoke a metadata function that uses this class.

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Redshift Connector Changes
* Fix Redshift connector runtime failure due to missing dependency on ``com.amazonaws.util.StringUtils``.
Add ``aws-java-sdk-core`` as a runtime dependency to support Redshift JDBC driver (v2.1.0.32) which relies on this class for metadata operations.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: adkharat / name: Ajay Kharat (b837afc)

[adkharat]

<dependency>
    <groupId>com.amazonaws</groupId>
    <artifactId>aws-java-sdk-core</artifactId>
    <scope>runtime</scope>
</dependency>

Redshift JDBC driver internally use com.amazonaws.util.StringUtils at runtime. So added scope of runtime.

[imjalpreet]

Minor comment, otherwise LGTM.

If possible, could you attach a screenshot of a successful query to Redshift after adding this fix?

[imjalpreet]

We don't need this, aws-java-sdk-core is already included in the root POM.

presto/pom.xml

Lines 1760 to 1778 in 91a8685

	<dependency>
	<groupId>com.amazonaws</groupId>
	<artifactId>aws-java-sdk-core</artifactId>
	<version>${dep.aws-sdk.version}</version>
	<exclusions>
	<exclusion>
	<groupId>commons-logging</groupId>
	<artifactId>commons-logging</artifactId>
	</exclusion>
	<exclusion>
	<groupId>joda-time</groupId>
	<artifactId>joda-time</artifactId>
	</exclusion>
	<exclusion>
	<groupId>org.apache.httpcomponents</groupId>
	<artifactId>httpclient</artifactId>
	</exclusion>
	</exclusions>
	</dependency>

[steveburnett]

Thanks for the release note! Just a nit. Should this entry be in Redshift Connector Changes instead of General Changes, like so?

== RELEASE NOTES ==

Redshift Connector Changes
* Fix Redshift connector runtime failure due to missing dependency on ``com.amazonaws.util.StringUtils``.
Add ``aws-java-sdk-core`` as a runtime dependency to support Redshift JDBC driver (v2.1.0.32) which relies on this class for metadata operations.

[adkharat]

@imjalpreet Correct, aws-java-sdk-core is already included in root pom.xml

• Scenario-1: Removing aws-java-sdk-core from presto-redshift/pom.xml causes a runtime error:
  Query failed: com/amazonaws/util/StringUtils

I think, Root pom.xml defines it, but not for plugin packaging:
The presto-redshift module produces a plugin (<packaging>presto-plugin</packaging>), which requires all needed runtime dependencies to be included explicitly in its own module, even if they exist in the parent pom.xml.

• Scenario-2: On keeping aws-java-sdk-core dependency in presto-redshift/pom.xml, I see CREATE TABLE execute successfully.

[adkharat]

Thanks for the release note! Just a nit. Should this entry be in Redshift Connector Changes instead of General Changes, like so?

== RELEASE NOTES ==

Redshift Connector Changes
* Fix Redshift connector runtime failure due to missing dependency on ``com.amazonaws.util.StringUtils``.
Add ``aws-java-sdk-core`` as a runtime dependency to support Redshift JDBC driver (v2.1.0.32) which relies on this class for metadata operations.

Correct. Updated

[imjalpreet]

Scenario-1: Removing aws-java-sdk-core from presto-redshift/pom.xml causes a runtime error:
Query failed: com/amazonaws/util/StringUtils

I think, Root pom.xml defines it, but not for plugin packaging:
The presto-redshift module produces a plugin (presto-plugin), which requires all needed runtime dependencies to be included explicitly in its own module, even if they exist in the parent pom.xml.

We need to keep the dependency in presto-redshift pom.xml, my comment was about removing the DependencyManagement section, as we don't need it.

[adkharat]

Scenario-1: Removing aws-java-sdk-core from presto-redshift/pom.xml causes a runtime error:
Query failed: com/amazonaws/util/StringUtils

I think, Root pom.xml defines it, but not for plugin packaging:
The presto-redshift module produces a plugin (presto-plugin), which requires all needed runtime dependencies to be included explicitly in its own module, even if they exist in the parent pom.xml.

We need to keep the dependency in presto-redshift pom.xml, my comment was about removing the DependencyManagement section, as we don't need it.

@imjalpreet Done

[imjalpreet]

LGTM

[prestodb-ci]

@ethanyzhang imported this issue as lakehouse/presto #25265