Skip to content

Use RouterRequestInfo in router schedulers to get the URL destination#25244

Merged
pdabre12 merged 1 commit intoprestodb:masterfrom
pdabre12:modify-getDestination
Jun 4, 2025
Merged

Use RouterRequestInfo in router schedulers to get the URL destination#25244
pdabre12 merged 1 commit intoprestodb:masterfrom
pdabre12:modify-getDestination

Conversation

@pdabre12
Copy link
Contributor

@pdabre12 pdabre12 commented Jun 3, 2025

Description

Use RouterRequestInfo in router schedulers to get the URL destination instead of having multiple getDestination variants.

Motivation and Context

Refactor to use a RouterRequestInfo POJO and remove the extra getDestination variant in router schedulers.

Impact

No impact

Test Plan

Unit tests.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Replace the parameters in router schedulers to use `RouterRequestInfo` to get the URL destination.

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jun 3, 2025
@pdabre12 pdabre12 marked this pull request as ready for review June 4, 2025 15:43
@pdabre12 pdabre12 requested a review from a team as a code owner June 4, 2025 15:43
@pdabre12 pdabre12 requested a review from hantangwangd June 4, 2025 15:43
@prestodb-ci prestodb-ci requested review from a team, anandamideShakyan and infvg and removed request for a team June 4, 2025 15:43
@pdabre12
Copy link
Contributor Author

pdabre12 commented Jun 4, 2025

@ZacBlanco @tdcmeehan @aaneja Can you folks please take a look?

@pdabre12 pdabre12 merged commit 58e8489 into prestodb:master Jun 4, 2025
100 of 110 checks passed
@pdabre12 pdabre12 deleted the modify-getDestination branch June 4, 2025 17:52
@prestodb-ci prestodb-ci mentioned this pull request Jul 28, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants