Skip to content

[native] Make PeriodicMemoryChecker::stop() virtual#25239

Merged
tanjialiang merged 1 commit intoprestodb:masterfrom
tanjialiang:export-D75322220
Jun 3, 2025
Merged

[native] Make PeriodicMemoryChecker::stop() virtual#25239
tanjialiang merged 1 commit intoprestodb:masterfrom
tanjialiang:export-D75322220

Conversation

@tanjialiang
Copy link
Contributor

@tanjialiang tanjialiang commented Jun 3, 2025

Make the stop method virtual so that it is overridable.

Summary:
Make control of the internal memory pushback as following:
1) PeriodicMemoryChecker::systemMemLimitBytes controls the main server pushback.
2) FacebookPeriodicMemoryChecker::jemallocPurgeResidentLimitBytes_ and FacebookPeriodicMemoryChecker::jemallocPurgeDirtyLimitBytes_ controls the asynchronous pushback for jemalloc purge

Reviewed By: xiaoxmeng

Differential Revision: D75322220
@tanjialiang tanjialiang requested a review from a team as a code owner June 3, 2025 05:35
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jun 3, 2025
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D75322220

@tanjialiang tanjialiang changed the title [prestissimo] Add async pushback for jemalloc purge [native] Make PeriodicMemoryChecker::stop() virtual Jun 3, 2025
@tanjialiang tanjialiang merged commit d5b7770 into prestodb:master Jun 3, 2025
104 of 110 checks passed
@prestodb-ci prestodb-ci mentioned this pull request Jul 28, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants