Skip to content

convert MemoryManagerOptions to MemoryManager::Options #25229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skyelves merged 1 commit into from
May 30, 2025
Merged

convert MemoryManagerOptions to MemoryManager::Options #25229

skyelves merged 1 commit into from
May 30, 2025

Conversation

@skyelves
Copy link
Member

@skyelves skyelves commented May 30, 2025 •
edited
Loading

Description

convert MemoryManagerOptions to MemoryManager::Options

Motivation and Context

refactor

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@skyelves skyelves requested a review from a team as a code owner May 30, 2025 21:12
tanjialiang
tanjialiang approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@tanjialiang tanjialiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can we remove the unnecessary sections from the PR description?

@skyelves skyelves merged commit e93a5f8 into prestodb:master May 30, 2025
112 of 113 checks passed
@unidevel unidevel mentioned this pull request Jun 19, 2025
Closed
6 tasks
This was referenced Jul 4, 2025
Merged
Closed
Closed
This was referenced Jul 24, 2025
Merged
Merged
@prestodb-ci prestodb-ci mentioned this pull request Jul 28, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanjialiang tanjialiang tanjialiang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skyelves @tanjialiang