Share code between router ui and presto ui#25223
Merged
yhwang merged 9 commits intoprestodb:masterfrom Jun 12, 2025
Merged
Conversation
auden-woolfson
force-pushed
the
share_router_ui_code
branch
from
7dbf84c to
baa2d41
Compare
ZacBlanco
reviewed
Jun 5, 2025
Contributor
ZacBlanco
left a comment
ZacBlanco
left a comment
There was a problem hiding this comment.
let's double check which dependencies are already vendored and make sure we reference those rather than introducing a copy in a separate tree
presto-ui/src/static/router/vendor/bootstrap/css/bootstrap-grid.css
Outdated
Show resolved
Hide resolved
move the jsx and html pages to presto-ui project and reuse the vendor, assets, and deps there to build the presto-router page. Signed-off-by: Yihong Wang <yh.wang@ibm.com>
prestodb-ci
requested review from
a team,
pramodsatya and
sh-shamsan
and removed request for
a team
Member
|
@ZacBlanco thanks for the review. I thought one of the commits is from me, I shouldn't be qualified to approve it. @auden-woolfson thanks for fixing the flow errors. let me just squash and merge it. |
6 tasks
anandamideShakyan
pushed a commit
to anandamideShakyan/presto
that referenced
this pull request
Jun 19, 2025
## Description Reduce code repetition on the UI side. The router ui shares a lot of resources with the main presto ui, so they don't need to be defined twice in the code base. ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == RELEASE NOTES == General Changes * ... * ... ``` --------- Signed-off-by: auden-woolfson <auden.woolfson@ibm.com> Co-authored-by: Yihong Wang <yh.wang@ibm.com>
This was referenced Jul 4, 2025
7 tasks
This was referenced Jul 24, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce code repetition on the UI side. The router ui shares a lot of resources with the main presto ui, so they don't need to be defined twice in the code base.
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.